Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] HybridGlobalization, SoftHypen is not ignored when it should be #95473

Closed
ilonatommy opened this issue Nov 30, 2023 · 1 comment · Fixed by #105946
Closed

[browser] HybridGlobalization, SoftHypen is not ignored when it should be #95473

ilonatommy opened this issue Nov 30, 2023 · 1 comment · Fixed by #105946
Assignees
@ilonatommy
Labels
arch-wasm WebAssembly architecture area-System.Globalization in-pr There is an active PR which will close this issue when it is merged
Milestone
Future

Comments

@ilonatommy
Copy link
Member

ilonatommy commented Nov 30, 2023 •
edited
Loading

See test data StartsWith_StringComparison_TestData. "\u00ADHello" and "Hello" is expected to be treated the same and as the consequence, "Hello".StartsWith("\u00ADHel") is expected to return true.
Should we add soft hypen to normalization step and ignore it for StringComparison.CurrentCulture? If we cannot do anything about it, add it to known platform differences in the docs.

The failing tests are using mono_wasm_index_of.
@ghost
Copy link

ghost commented Nov 30, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

See test data StartsWith_StringComparison_TestData. "\u00ADHello" and "Hello" is expected to be treated the same and as the consequence, "Hello".StartsWith("\u00ADHel") is expected to return true.
Should we add soft hypen to normalization step and ignore it for StringComparison.CurrentCulture? If we cannot do anything about it, add it to known platform differences in the docs.

Author: ilonatommy
Assignees: -
Labels:

arch-wasm, area-System.Globalization
Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 30, 2023
@radical radical removed the untriaged New issue has not been triaged by the area owner label Nov 30, 2023
@ilonatommy ilonatommy mentioned this issue Dec 1, 2023
Merged
@lewing lewing added this to the Future milestone May 2, 2024
@ilonatommy ilonatommy self-assigned this Jun 28, 2024
@ilonatommy ilonatommy mentioned this issue Aug 5, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Globalization in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

[browser] Fix HybridGlobalization, SoftHyphen is not ignored when it should be ilonatommy/runtime
3 participants
@radical @lewing @ilonatommy