-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
outerloop-nightly is broken because "native test components" is unavailable #85263
Comments
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsIt seems that we skip to upload the "native test components" because of which all the test jobs in runtime/eng/pipelines/coreclr/templates/build-job.yml Lines 294 to 305 in c3a2bce
vs. and the download job for
|
It seems to me that the problem is that we're not setting the parameter https://dev.azure.com/dnceng-public/public/_build?definitionId=135&_a=summary vs. https://dev.azure.com/dnceng-public/public/_build?definitionId=108&_a=summary In particular, I believe that in our Monday backlog sync-ups JeffSchw looks at the latter so if the intent was to improve outerloop coverage by implementing some checked vs. release build variations, it would seem logical to me to add them to the existing outerloop run instead of creating a new one. By the way, even though it doesn't seem to be the root problem here, the pipeline template |
Agree. |
I have looked at the GitHub history and it looks like the |
I have triggered an experimental run with my proposed fix for the pipeline: It's only just started but I do see the "Zip / publish native test components" steps in the CoreCLR build jobs. I can send it out for PR if the test finishes fine; we can then have a secondary discussion regarding its potential consolidation with the other outerloop pipeline. |
Sounds good to me. |
OK, so it's far from green (I haven't found any previous green run of the pipeline) but at least it's now actually sending the tests to Helix and just a handful of them is failing, a few test execution jobs have passed. I'm going to go ahead and publish the PR now as a general goodness, I think that some of the test failures are really interesting in terms of test coverage, we may have been missing some of them previously due to using checked builds in the |
@TIHan FYI. Please consider checking the unique failures and open issues as appropriate. |
It seems that we skip to upload the "native test components" because of which all the test jobs in
outerloop-nightly
fails because it tries to download those artifacts but doesn't find it. The conditions to skip uploading seems legitimate, so not sure if we should skip downloading them as well with the same conditions check.runtime/eng/pipelines/coreclr/templates/build-job.yml
Lines 294 to 305 in c3a2bce
runtime pipeline
vs.
outerloop-nightly pipeline
and the download job for
native test components
keep failing.The text was updated successfully, but these errors were encountered: