Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume DivRem intrinsics from Math.DivRem #82194

Open
kunalspathak opened this issue Feb 15, 2023 · 4 comments
Open

Consume DivRem intrinsics from Math.DivRem #82194

kunalspathak opened this issue Feb 15, 2023 · 4 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@kunalspathak
Copy link
Member

kunalspathak commented Feb 15, 2023 •
edited
Loading

#66551 adds intrinsic for DivRem and we should start consuming it from Math.DivRem. However, currently there are some code gen optimizations that we should do to generate a better code using DivRemintrinsic compared to what we generate today for current implementation.

Also remove [RequiresPreviewFeatures] attribute from DivRem APIs.

See discussion: #66551 (comment)
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 15, 2023
@kunalspathak kunalspathak mentioned this issue Feb 15, 2023
Merged
@kunalspathak kunalspathak added this to the 8.0.0 milestone Feb 16, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Feb 16, 2023
@kunalspathak kunalspathak mentioned this issue Feb 16, 2023
Merged
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 17, 2023
@SingleAccretion SingleAccretion added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 17, 2023
@ghost
Copy link

ghost commented Feb 17, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

#66551 adds intrinsic for DivRem and we should start consuming it from Math.DivRem. However, currently there are some code gen optimizations that we should do to generate a better code using DivRemintrinsic compared to what we generate today for current implementation.

Also remove [RequiresPreviewFeatures] attribute from DivRem APIs.

See discussion: #66551 (comment)

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: 8.0.0

@BrennanConroy BrennanConroy mentioned this issue May 22, 2023
Merged
@pentp pentp mentioned this issue Jul 6, 2023
Closed
@tannergooding tannergooding modified the milestones: 8.0.0, 9.0.0 Aug 8, 2023
@tannergooding
Copy link
Member

We won't get to this for .NET 8.

@tannergooding tannergooding removed their assignment Apr 18, 2024
@JulieLeeMSFT JulieLeeMSFT modified the milestones: 9.0.0, Future Apr 18, 2024
@JulieLeeMSFT
Copy link
Member

Moving to future. More complex change only relevant to fairly new support in the JIT.

@tannergooding tannergooding mentioned this issue Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@tannergooding @kunalspathak @SingleAccretion @JulieLeeMSFT