Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Update emsdk to latest #80784

Closed
lewing opened this issue Jan 18, 2023 · 5 comments
Closed

[wasm] Update emsdk to latest #80784

lewing opened this issue Jan 18, 2023 · 5 comments
Assignees
@radekdoulik
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Milestone
8.0.0

Comments

@lewing
Copy link
Member

lewing commented Jan 18, 2023

The threading work requires an emscripten bump and our current build is fairly old
@lewing lewing added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Jan 18, 2023
@lewing lewing added this to the 8.0.0 milestone Jan 18, 2023
@ghost
Copy link

ghost commented Jan 18, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

The threading work requires an emscripten bump and our current build is fairly old

Author: lewing
Assignees: radekdoulik
Labels:

arch-wasm, area-Infrastructure-mono
Milestone: 8.0.0

@lewing lewing changed the title [wasm] Update emsdk to lateset [wasm] Update emsdk to latest Jan 18, 2023
@lewing
Copy link
Member Author

lewing commented Jan 23, 2023

keep an eye out for emscripten-core/emscripten#18191

@lewing
Copy link
Member Author

lewing commented Jan 23, 2023 •
edited
Loading

@pavelsavara we should expose those values as msbuild properties and share them with the wasi build (like set a global in driver.c that wasm_get_stack_size uses)

@pavelsavara
Copy link
Member

There is also this llvm/llvm-project@1532be9 for the main thread. I don't know if the emsdk bump already contains this LLVM update.

For the MT we will need pthread_attr_getstack on emscripten or something like that.
WASI alternative doesn't exist yet afaik.

@radekdoulik radekdoulik mentioned this issue Jan 26, 2023
Merged
@radekdoulik
Copy link
Member

The emscripten was updated for NET8 to version suitable for our MT support, currently we are at 3.1.34

@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radekdoulik radekdoulik

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@lewing @pavelsavara @radekdoulik