Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.IO.Hashing's ref is missing a csproj #77846

Closed
stephentoub opened this issue Nov 3, 2022 · 2 comments · Fixed by #77856
Closed

System.IO.Hashing's ref is missing a csproj #77846

stephentoub opened this issue Nov 3, 2022 · 2 comments · Fixed by #77856

Comments

@stephentoub
Copy link
Member

stephentoub commented Nov 3, 2022

As far as I can tell, it's the only ref folder in all of libraries that lacks one. Whether or not we're publishing a ref assembly in the nuget package, it means the System.IO.Hashing.cs in that folder isn't being validated.

cc: @ViktorHofer, @bartonjs

@stephentoub stephentoub added this to the 8.0.0 milestone Nov 3, 2022
@ghost
Copy link

ghost commented Nov 3, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

As far as I can tell, it's the only ref folder in all of libraries that lacks one. Whether or not we're publishing a ref in the nuget package, it means the System.IO.Hashing.cs in that folder isn't being validated.

cc: @ViktorHofer, @bartonjs

Author: stephentoub
Assignees: -
Labels:

area-System.Security

Milestone: 8.0.0

@bartonjs
Copy link
Member

bartonjs commented Nov 3, 2022

Back in #53623 (comment) (and slightly above) it had been brought up, I said I copied what System.Formats.Asn1 did, there were some nods of agreement, and we all moved on.

But since System.Formats.Asn1\ref does have a csproj... I no longer know what's what.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 3, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants