Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive Promotion of structs containing fields of structs with a single pointer-sized field #7576

Closed
sivarv opened this issue Mar 8, 2017 · 1 comment · Fixed by #88090
Closed

Recursive Promotion of structs containing fields of structs with a single pointer-sized field #7576

sivarv opened this issue Mar 8, 2017 · 1 comment · Fixed by #88090
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions optimization Priority:2 Work that is important, but not critical for the release tenet-performance Performance related issue
Milestone
8.0.0

Comments

@sivarv
Copy link
Member

sivarv commented Mar 8, 2017 •
edited by BruceForstall
Loading

The current implementation lies about the type of struct field as the type of its underlying scalar field. Because of which, in some cases it could lead to an IR where either RHS or LHS of copyblk asg is a scalar type var. These cases has following limitations

  1. LHS is a scalar local var. This will be marked as DoNotEnregister by fgMorphCopyblk
  2. RHS is a scalar local var. AssertionProp will not perform const prop on RHS such an asg since copyblk could be incorrectly considered as initblk by morph logic.

These two limitations could be avoided by implementing recursive struct promotion.

category:cq
theme:structs
skill-level:expert
cost:large
impact:medium
@sivarv sivarv assigned sivarv and JosephTremoulet and unassigned sivarv Mar 8, 2017
@pgavlin
Copy link
Contributor

pgavlin commented Jun 20, 2017

@russellhadley @JosephTremoulet is this done?

@JosephTremoulet JosephTremoulet removed their assignment Sep 14, 2017
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@erozenfeld erozenfeld mentioned this issue Jun 5, 2020
Closed
@jakobbotsch jakobbotsch mentioned this issue Dec 15, 2022
Closed
40 tasks
@jakobbotsch jakobbotsch mentioned this issue Apr 30, 2023
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 30, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 3, 2023
@jakobbotsch jakobbotsch self-assigned this Jun 16, 2023
@jakobbotsch jakobbotsch modified the milestones: Future, 8.0.0 Jun 16, 2023
@jakobbotsch jakobbotsch added the Priority:2 Work that is important, but not critical for the release label Jun 20, 2023
@jakobbotsch jakobbotsch mentioned this issue Jun 27, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 27, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 29, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions optimization Priority:2 Work that is important, but not critical for the release tenet-performance Performance related issue
Projects
None yet
Milestone
8.0.0
5 participants
@pgavlin @jakobbotsch @msftgits @JosephTremoulet @sivarv