Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve StaticCS.0.1.0 source-build prebuilt #73025

Closed
MichaelSimons opened this issue Jul 28, 2022 · 3 comments
Closed

Resolve StaticCS.0.1.0 source-build prebuilt #73025

MichaelSimons opened this issue Jul 28, 2022 · 3 comments

Comments

@MichaelSimons
Copy link
Member

StaticCS.0.1.0 is being reported as a prebuilt in .NET 7.0. Source-build must build the entire dependency graph of the product. A prebuilt is a dependency that is referenced outside this graph. This prebuilt appears to have been introduced by #71485.

See the source-build guidance for adding new dependencies for additional details.

It may be useful to reference how this prebuilt was recently resolved in linker. dotnet/linker#2902.

cc @vitek-karas @agocke

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 28, 2022
@agocke
Copy link
Member

agocke commented Jul 29, 2022

I fixed this in the linker so the next file copy over should bring over the fix as well

@vitek-karas vitek-karas added this to the 7.0.0 milestone Aug 4, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 4, 2022
@vitek-karas
Copy link
Member

#73380 should fix this - it brings the changes from linker repo (or rather duplicates them adapted to runtime repo)

@sbomer
Copy link
Member

sbomer commented Aug 9, 2022

Closing since #73380 is merged.

@sbomer sbomer closed this as completed Aug 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Archived in project
Development

No branches or pull requests

5 participants