Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Text.Json instances of polymorphic types emit type discriminator when serialized as object types #72187

Closed
eiriktsarpalis opened this issue Jul 14, 2022 · 1 comment · Fixed by #72789
Closed

System.Text.Json instances of polymorphic types emit type discriminator when serialized as object types #72187

eiriktsarpalis opened this issue Jul 14, 2022 · 1 comment · Fixed by #72789
Assignees
@eiriktsarpalis
Labels
area-System.Text.Json bug
Milestone
7.0.0

Comments

@eiriktsarpalis
Copy link
Member

Creating an issue to track

https://github.com/dotnet/runtime/blob/main/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PolymorphicTests.CustomTypeHierarchies.cs#L937-L943
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 14, 2022
@ghost
Copy link

ghost commented Jul 14, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Creating an issue to track

https://github.com/dotnet/runtime/blob/main/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PolymorphicTests.CustomTypeHierarchies.cs#L937-L943

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

@eiriktsarpalis eiriktsarpalis mentioned this issue Jul 14, 2022
Merged
@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Jul 14, 2022
@eiriktsarpalis eiriktsarpalis self-assigned this Jul 14, 2022
@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Jul 14, 2022
This was referenced Jul 22, 2022
Merged
Closed
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 25, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Refactor root-level serialization logic and polymorphic value handling. eiriktsarpalis/runtime
1 participant
@eiriktsarpalis