Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono minijit x64 test failure: loopinfinally_do.dll exception #68187

Closed
carlossanlop opened this issue Apr 18, 2022 · 9 comments · Fixed by #68215
Closed

mono minijit x64 test failure: loopinfinally_do.dll exception #68187

carlossanlop opened this issue Apr 18, 2022 · 9 comments · Fixed by #68215
Assignees
Labels
area-Infrastructure blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Milestone

Comments

@carlossanlop
Copy link
Member

mono minijit Pri0 Runtime Tests Run windows x64 release

Example: https://dev.azure.com/dnceng/public/_build/results?buildId=1724655&view=logs&j=fea05fe8-29db-5d00-a4a9-158748ab7a12&t=2e9f2958-4d0a-5332-1dee-76b00780168f&l=104

Failing test:

23:10:54.365 Passed test: JIT/Methodical/int64/unsigned/ldsfld_mulovf_do/ldsfld_mulovf_do.dll
23:10:54.365 Running test: JIT/Methodical/eh/finallyexec/loopinfinally_do/loopinfinally_do.dll
Caught an exception
In finally, i = 3
In finally, i = 4
Expected: 100
Actual: -1073741819
END EXECUTION - FAILED
FAILED
@carlossanlop carlossanlop added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' JitUntriaged CLR JIT issues needing additional triage labels Apr 18, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Apr 18, 2022
@ghost
Copy link

ghost commented Apr 18, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

mono minijit Pri0 Runtime Tests Run windows x64 release

Example: https://dev.azure.com/dnceng/public/_build/results?buildId=1724655&view=logs&j=fea05fe8-29db-5d00-a4a9-158748ab7a12&t=2e9f2958-4d0a-5332-1dee-76b00780168f&l=104

Failing test:

23:10:54.365 Passed test: JIT/Methodical/int64/unsigned/ldsfld_mulovf_do/ldsfld_mulovf_do.dll
23:10:54.365 Running test: JIT/Methodical/eh/finallyexec/loopinfinally_do/loopinfinally_do.dll
Caught an exception
In finally, i = 3
In finally, i = 4
Expected: 100
Actual: -1073741819
END EXECUTION - FAILED
FAILED
Author: carlossanlop
Assignees: -
Labels:

area-CodeGen-coreclr, blocking-clean-ci, untriaged, JitUntriaged

Milestone: -

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Apr 18, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Apr 18, 2022
@JulieLeeMSFT
Copy link
Member

@jakobbotsch this is blocking CI. PTAL with a high priority.

@elinor-fung
Copy link
Member

elinor-fung commented Apr 18, 2022

loopinfinally_do is supposed to be excluded from mono runs on Windows:

<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/eh/finallyexec/loopinfinally_do/*">
<Issue>https://github.com/dotnet/runtime/issues/65704</Issue>
</ExcludeList>

@trylek @jkoritzinsky could this be related to the merged test work in #65597?

@elinor-fung
Copy link
Member

KeepAliveBoxOpt is also running (and failing) even though it should be excluded on mono:

<ExcludeList Include="$(XunitTestBinBase)/JIT/Methodical/Boxing/boxunbox/KeepAliveBoxOpt/**">
<Issue>Relies on precise finalization and thus precise GC</Issue>
</ExcludeList>

@trylek
Copy link
Member

trylek commented Apr 19, 2022

I'm taking a look now, for sure it may be related, thanks for the heads-up.

@trylek
Copy link
Member

trylek commented Apr 19, 2022

@jkoritzinsky - at the first glance this looks like a mismatch between the forward and backward slashes in TestExclusionList. Should we always put forward slashes in the list?

@jkoritzinsky
Copy link
Member

If that's the issue, then we definitely need to add some normalization. I think changing all of the slashes to be forward slashes (Unix style) would be the easiest.

@jakobbotsch jakobbotsch added area-Infrastructure and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitUntriaged CLR JIT issues needing additional triage labels Apr 19, 2022
@ghost
Copy link

ghost commented Apr 19, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

mono minijit Pri0 Runtime Tests Run windows x64 release

Example: https://dev.azure.com/dnceng/public/_build/results?buildId=1724655&view=logs&j=fea05fe8-29db-5d00-a4a9-158748ab7a12&t=2e9f2958-4d0a-5332-1dee-76b00780168f&l=104

Failing test:

23:10:54.365 Passed test: JIT/Methodical/int64/unsigned/ldsfld_mulovf_do/ldsfld_mulovf_do.dll
23:10:54.365 Running test: JIT/Methodical/eh/finallyexec/loopinfinally_do/loopinfinally_do.dll
Caught an exception
In finally, i = 3
In finally, i = 4
Expected: 100
Actual: -1073741819
END EXECUTION - FAILED
FAILED
Author: carlossanlop
Assignees: jakobbotsch
Labels:

blocking-clean-ci, area-Infrastructure

Milestone: 7.0.0

@jakobbotsch jakobbotsch assigned trylek and unassigned jakobbotsch Apr 19, 2022
@jakobbotsch
Copy link
Member

This does not look codegen related, so reassigning based on above discussion.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 19, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants