Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Potential perf regression in Timer #59150

Closed
adamsitnik opened this issue Sep 15, 2021 · 2 comments
Closed

[macOS] Potential perf regression in Timer #59150

adamsitnik opened this issue Sep 15, 2021 · 2 comments
Labels
area-System.Threading os-mac-os-x macOS aka OSX tenet-performance Performance related issue
Milestone
8.0.0

Comments

@adamsitnik
Copy link
Member

It seems to be affecting only macOS (cc @Lxiamail @jeffhandley)

git clone https://github.com/dotnet/performance.git
python3 ./performance/scripts/benchmarks_ci.py -f net5.0 net6.0 --filter System.Threading.Tests.Perf_Timer.ShortScheduleAndDisposeWithFiringTimers
Result Ratio Operating System
Same 1.06 Windows 10.0.19043.1165
Same 0.93 Windows 10.0.20348
Same 1.11 Windows 10.0.20348
Same 1.00 Windows 10.0.18363.1621
Same 0.91 Windows 8.1
Same 1.01 Windows 10.0.19042.685
Same 1.01 Windows 10.0.19043.1165
Same 1.01 Windows 10.0.22454
Same 1.07 Windows 10.0.22451
Same 0.97 Windows 10.0.19042.1165
Slower 0.70 Windows 7 SP1
Same 1.06 centos 8
Same 1.02 debian 10
Same 1.01 rhel 7
Faster 1.15 sles 15
Same 1.08 opensuse-leap 15.3
Same 1.10 ubuntu 18.04
Same 1.01 ubuntu 18.04
Same 1.02 alpine 3.13
Same 1.08 ubuntu 16.04
Same 1.06 Windows 10.0.19043.1165
Same 1.00 Windows 10.0.22000
Same 0.98 Windows 10.0.19043.1165
Same 1.00 Windows 10.0.18363.1621
Same 1.02 Windows 10.0.19043.1165
Slower 0.82 macOS Big Sur 11.5.2
Slower 0.75 macOS Big Sur 11.5.2
Slower 0.77 macOS Big Sur 11.4
@adamsitnik adamsitnik added area-System.Threading os-mac-os-x macOS aka OSX tenet-performance Performance related issue labels Sep 15, 2021
@ghost
Copy link

ghost commented Sep 15, 2021

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

It seems to be affecting only macOS (cc @Lxiamail @jeffhandley)

git clone https://github.com/dotnet/performance.git
python3 ./performance/scripts/benchmarks_ci.py -f net5.0 net6.0 --filter System.Threading.Tests.Perf_Timer.ShortScheduleAndDisposeWithFiringTimers
Result Ratio Operating System
Same 1.06 Windows 10.0.19043.1165
Same 0.93 Windows 10.0.20348
Same 1.11 Windows 10.0.20348
Same 1.00 Windows 10.0.18363.1621
Same 0.91 Windows 8.1
Same 1.01 Windows 10.0.19042.685
Same 1.01 Windows 10.0.19043.1165
Same 1.01 Windows 10.0.22454
Same 1.07 Windows 10.0.22451
Same 0.97 Windows 10.0.19042.1165
Slower 0.70 Windows 7 SP1
Same 1.06 centos 8
Same 1.02 debian 10
Same 1.01 rhel 7
Faster 1.15 sles 15
Same 1.08 opensuse-leap 15.3
Same 1.10 ubuntu 18.04
Same 1.01 ubuntu 18.04
Same 1.02 alpine 3.13
Same 1.08 ubuntu 16.04
Same 1.06 Windows 10.0.19043.1165
Same 1.00 Windows 10.0.22000
Same 0.98 Windows 10.0.19043.1165
Same 1.00 Windows 10.0.18363.1621
Same 1.02 Windows 10.0.19043.1165
Slower 0.82 macOS Big Sur 11.5.2
Slower 0.75 macOS Big Sur 11.5.2
Slower 0.77 macOS Big Sur 11.4
Author: adamsitnik
Assignees: -
Labels:

area-System.Threading, os-mac-os-x, tenet-performance
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Sep 15, 2021
@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Sep 15, 2021
@mangod9 mangod9 added this to the 7.0.0 milestone Sep 15, 2021
@adamsitnik adamsitnik mentioned this issue Sep 17, 2021
Closed
19 tasks
@mangod9 mangod9 modified the milestones: 7.0.0, 8.0.0 Jul 19, 2022
@mangod9
Copy link
Member

mangod9 commented Jul 13, 2023

I am going to close this since customers havent reported any perf concerns with this.

@mangod9 mangod9 closed this as completed Jul 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Threading os-mac-os-x macOS aka OSX tenet-performance Performance related issue
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
2 participants
@adamsitnik @mangod9