Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mono behavior for conv.ovf.<to type>.un. #56784

Closed
sandreenko opened this issue Aug 3, 2021 · 0 comments · Fixed by #57048
Closed

Mono behavior for conv.ovf.<to type>.un. #56784

sandreenko opened this issue Aug 3, 2021 · 0 comments · Fixed by #57048
Assignees
@BrzVlad
Labels
area-Codegen-JIT-mono bug disabled-test The test is disabled in source code against the issue
Milestone
6.0.0

Comments

@sandreenko
Copy link
Contributor

Ecma standart was not clear about the result of:

      ldc.r4       -1.0
      conv.ovf.i1.un

#53189

so we clarified it in #56450 and added a new test and now it is failing on mono, because mono checks the value to be positive before the conv. I have disabled the test for now. These are failures example: https://dev.azure.com/dnceng/public/_build/results?buildId=1271733&view=ms.vss-test-web.build-test-results-tab&runId=37619764&resultId=100229&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Aug 3, 2021
@SamMonoRT SamMonoRT added disabled-test The test is disabled in source code against the issue and removed untriaged New issue has not been triaged by the area owner labels Aug 4, 2021
@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Aug 4, 2021
@BrzVlad BrzVlad mentioned this issue Aug 8, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 8, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BrzVlad BrzVlad

Labels
area-Codegen-JIT-mono bug disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

[mono] Fix conversions from float to integer BrzVlad/runtime
3 participants
@BrzVlad @sandreenko @SamMonoRT