Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing VS pre-req leads to non-obvious build error #45610

Closed
bwadswor opened this issue Dec 4, 2020 · 3 comments
Closed

Missing VS pre-req leads to non-obvious build error #45610

bwadswor opened this issue Dec 4, 2020 · 3 comments

Comments

@bwadswor
Copy link
Member

bwadswor commented Dec 4, 2020

Initial cost estimate: 2 days
Initial contacts: @trylek, @ViktorHofer

Description

Would be nice if missing dependencies were flagged clearly in the build.

Steps to Repro

  1. starting with a clean machine, install all the pre-reqs except for VS2019. (i just failed to install it...)

https://github.com/dotnet/runtime/blob/master/docs/workflow/requirements/windows-requirements.md clearly lists VS as a pre-req.

  1. clone
  2. build.cmd
  3. observe error, and scratch head trying to figure out why it didn't work cleanly..

Fragment of Output from build

Restore was successful.
All projects are up-to-date for restore.
Determining projects to restore...
All projects are up-to-date for restore.
System.Private.CoreLib -> D:\CoreCLR6\runtime\artifacts\bin\coreclr\windows.x64.Debug\IL\System.Private.CoreLib.dll
DIALib -> D:\CoreCLR6\runtime\artifacts\bin\DIALib\Debug\DIALib.dll
D:\CoreCLR6\runtime.dotnet\sdk\5.0.100\Microsoft.Common.CurrentVersion.targets(4818,5): error MSB3030: Could not copy the file "D:\DIA SDK\bin\amd64\msdia140.dll" because it was not found. [D:\CoreCLR6\runtime\src\coreclr\src\ToolBox\SOS\DacTableGen\DacTableGen.csproj]

Hopeful

It'd be nice if this dependency (and frankly all dependencies) were nicely flagged as missing during build.

I've listed this one here as I hit it... and now others will quickly find this via issue search and know what to do...

I dont really expect that we spend much effort fixing this.. but if someone wanted to take a few moments that also wouldn't be bad....

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 4, 2020
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Dec 7, 2020
@tommcdon tommcdon added this to the 6.0.0 milestone Dec 7, 2020
@tommcdon
Copy link
Member

tommcdon commented Dec 7, 2020

@trylek

@ViktorHofer
Copy link
Member

Most of the discussion about this happened in #39052. I think we can close this as a dup of the original issue the PR is trying to fix.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants