-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Apple Silicon Diagnostics #45383
Comments
Tagging subscribers to this area: @tommcdon Issue Details
|
I am not aware of any missing profiler code in the runtime. The runtime profiler tests mostly just pass. Our internal profiler tests have not been run successfully yet, but that may or may not be a runtime issue. /cc @davmason |
The only feature that requires platform specific changes should be ELT hooks, everything else should be portable. We do run in to the issue where new platforms often require new APIs to handle different behavior - i.e. on Linux/Mac due to the way we cache environment variables in the PAL we had to add profiler APIs to set and get environment variables. I don't anticipate any of those for Apple Silicon, but it's a risk we run by not validating the scenario. I think it's the right risk to take, but worth calling out. |
BTW, I'm not aware of any issues with Profiling API on Apple Silicon (incl. ELT hooks). |
@k15tfu Thanks. I think the only known issue is that our internal profiler tests are not running yet. So there is a potential of an issue. |
We have minimal testing in the runtime repo. |
Our goal is to deliver parity with osx-x64 for apple silicon diagnosics.
The text was updated successfully, but these errors were encountered: