Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apple Silicon Diagnostics #45383

Closed
3 tasks done
Tracked by #5929
tommcdon opened this issue Nov 30, 2020 · 7 comments
Closed
3 tasks done
Tracked by #5929

Support Apple Silicon Diagnostics #45383

tommcdon opened this issue Nov 30, 2020 · 7 comments
Labels
arch-arm64 area-Diagnostics-coreclr Bottom Up Work Not part of a theme, epic, or user story os-mac-os-x macOS aka OSX User Story A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@tommcdon
Copy link
Member

tommcdon commented Nov 30, 2020

Our goal is to deliver parity with osx-x64 for apple silicon diagnosics.

  • Implement ICorDebug APIs
  • Test ICorProfiler APIs
  • SOS support
@tommcdon tommcdon added this to the 6.0.0 milestone Nov 30, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Nov 30, 2020
@ghost
Copy link

ghost commented Nov 30, 2020

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Implement ICorDebug APIs
  • Implement ICorProfiler APIs
  • SOS support
Author: tommcdon
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: 6.0.0

@tommcdon tommcdon added os-mac-os-x macOS aka OSX arch-arm64 and removed untriaged New issue has not been triaged by the area owner labels Nov 30, 2020
@tommcdon tommcdon added User Story A single user-facing feature. Can be grouped under an epic. Bottom Up Work Not part of a theme, epic, or user story labels Dec 9, 2020
@tommcdon
Copy link
Member Author

tommcdon commented Apr 9, 2021

Debugger API's completed on #47834, #42105

SOS supports Apple Silicon.

@sdmaclea
Copy link
Contributor

sdmaclea commented May 3, 2021

I am not aware of any missing profiler code in the runtime. The runtime profiler tests mostly just pass. Our internal profiler tests have not been run successfully yet, but that may or may not be a runtime issue.

/cc @davmason

@davmason
Copy link
Member

davmason commented May 4, 2021

The only feature that requires platform specific changes should be ELT hooks, everything else should be portable. We do run in to the issue where new platforms often require new APIs to handle different behavior - i.e. on Linux/Mac due to the way we cache environment variables in the PAL we had to add profiler APIs to set and get environment variables. I don't anticipate any of those for Apple Silicon, but it's a risk we run by not validating the scenario. I think it's the right risk to take, but worth calling out.

@k15tfu
Copy link
Contributor

k15tfu commented May 17, 2021

BTW, I'm not aware of any issues with Profiling API on Apple Silicon (incl. ELT hooks).

@sdmaclea
Copy link
Contributor

@k15tfu Thanks.

I think the only known issue is that our internal profiler tests are not running yet. So there is a potential of an issue.

@tommcdon
Copy link
Member Author

tommcdon commented Jul 6, 2021

We have minimal testing in the runtime repo.

@tommcdon tommcdon closed this as completed Jul 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-Diagnostics-coreclr Bottom Up Work Not part of a theme, epic, or user story os-mac-os-x macOS aka OSX User Story A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Development

No branches or pull requests

5 participants