-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PerfMap generation in Crossgen2 #44123
Comments
@davidwrighton / @janvorli - assuming I implement the PerfMap format, how do I go about testing it? I'm getting it's somehow related to PerfView and Linux, is the workflow described somewhere? |
One thing that comes to mind in particular is the function signature formatting; are we required to replicate CoreCLR MethodDesc formatting? |
OK, so technically both Crossgen2 and R2RDump support generating perfmaps now (as of #47019). I guess that the remaining bit needed to close this item is to actually validate that PerfMap works as expected. I performed a round of local testing of PDB generator using PerfView based on David's advice but I merged in the PerfMap generator based on just visual validation of the file format as there's currently no workflow in existence to actually exercise it. @brianrob, would you be willing to work with me on figuring out the plan for the next step i.e. switching perfcollect to somehow use the Crossgen2 / R2RDump infrastructure for generating R2R PerfMap files, validating the new diagnostic experience and ideally fixing this validation in terms of some diagnostic lab testing? |
@trylek, definitely. This is probably a relatively trivial change to perfcollect. It's important for versions of perf that can't process jitdumps (this is the format that the Linux perf tool can consume to resolve non-ELF symbols), but this is becoming less and less common. |
I believe that the remaining work on perfmap files is tracked by https://github.com/dotnet/sdk/issues/18813 and this issue can be closed. |
As part of replacing Crossgen with Crossgen2, we need an equivalent of the Crossgen option /CreatePerfMap.
The text was updated successfully, but these errors were encountered: