Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up VN for promoted fields assigned using the whole parent. #41242

Closed
4 tasks
sandreenko opened this issue Aug 24, 2020 · 2 comments · Fixed by #76139
Closed
4 tasks

Clean-up VN for promoted fields assigned using the whole parent. #41242

sandreenko opened this issue Aug 24, 2020 · 2 comments · Fixed by #76139
Assignees
@SingleAccretion
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
8.0.0

Comments

@sandreenko
Copy link
Contributor

sandreenko commented Aug 24, 2020 •
edited by BruceForstall
Loading

This is a follow-up for #37745 (comment) and #41197 (review).

category:implementation
theme:value-numbering
skill-level:expert
cost:medium
@sandreenko sandreenko added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 24, 2020
@sandreenko sandreenko added this to the 6.0.0 milestone Aug 24, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Aug 24, 2020
@sandreenko sandreenko self-assigned this Aug 24, 2020
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Aug 24, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@BruceForstall BruceForstall removed the JitUntriaged CLR JIT issues needing additional triage label Nov 10, 2020
@JulieLeeMSFT JulieLeeMSFT added the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Mar 23, 2021
@JulieLeeMSFT JulieLeeMSFT removed the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Jun 7, 2021
@sandreenko sandreenko modified the milestones: 6.0.0, 7.0.0 Jul 23, 2021
@sandreenko
Copy link
Contributor Author

It is a potential CQ improvement with medium required changes, out of scope for 6.0.

@jakobbotsch jakobbotsch mentioned this issue Aug 13, 2021
Merged
@briansull
Copy link
Contributor

briansull commented Aug 16, 2021 •
edited
Loading

This issue will be fixed in 6.0 by
PR #57282 - Fix VN incorrect optimizations with a new JitEEInterface function.

@SingleAccretion SingleAccretion modified the milestones: 7.0.0, 8.0.0 Jun 4, 2022
@SingleAccretion SingleAccretion mentioned this issue Sep 24, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 24, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SingleAccretion SingleAccretion

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Add IR support for modeling multiple SSA definitions as one store SingleAccretion/runtime
6 participants
@BruceForstall @briansull @sandreenko @Dotnet-GitSync-Bot @SingleAccretion @JulieLeeMSFT