Pmi run on some test dll-s hits some jit asserts.

[sandreenko]

I was running PMI on test using a command like this:

jit-diff.bat  diff  -b "D:\Sergey\git\runtime\artifacts\tests\coreclr\Windows_NT.x64.Checked\Tests\Core_Root"  --output D:\Sergey\diffs --core_root D:\Sergey\git\runtime\artifacts\tests\coreclr\Windows_NT.x64.Release\Tests\Core_Root --pmi --tests --test_root D:\Sergey\git\runtime\artifacts\tests\coreclr\Windows_NT.x64.Checked

and has hit many failures: Warning: Failures detected generating asm: 36, for example,
corerun pmi.dll PrepAll runtime\artifacts\tests\coreclr\Windows_NT.x64.Checked\JIT\Regression\CLR-x86-JIT\V1.2-Beta1\b210352\csharpgenerictypes\csharpgenerictypes.dll fails with:

PREPALL type# 1 method# 56 GenericClass`1[[System.Object, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]::StaticGenericMethodUsesClassTypeParam

Assert failure(PID 28340 [0x00006eb4], Thread: 68064 [0x109e0]): Assertion failed 'typeClass != nullptr' in 'ILStubClass:IL_STUB_InstantiatingStub(System.Object,System.Numerics.Vector`1[Single],System.Type):System.Numerics.Vector`1[Single]' during 'Importation' (IL size 27)

    File: D:\Sergey\git\runtime\src\coreclr\src\jit\compiler.hpp Line: 704
    Image: D:\Sergey\git\runtime\artifacts\tests\coreclr\Windows_NT.x64.Checked\Tests\Core_Root\CoreRun.exe

with stack like:

>	clrjit.dll!Compiler::VarTypeIsMultiByteAndCanEnreg(var_types type, CORINFO_CLASS_STRUCT_ * typeClass, unsigned int * typeSize, bool forReturn, bool isVarArg) Line 705	C++
 	clrjit.dll!Compiler::impTailCallRetTypeCompatible(var_types callerRetType, CORINFO_CLASS_STRUCT_ * callerRetTypeClass, var_types calleeRetType, CORINFO_CLASS_STRUCT_ * calleeRetTypeClass) Line 7388	C++
 	clrjit.dll!Compiler::impImportCall(opcode_t opcode, CORINFO_RESOLVED_TOKEN * pResolvedToken, CORINFO_RESOLVED_TOKEN * pConstrainedResolvedToken, GenTree * newobjThis, int prefixFlags, CORINFO_CALL_INFO * callInfo, unsigned int rawILOffset) Line 8578	C++

Has anybody seen this behaviour? Is it expected or jit or pmi issue? @dotnet/jit-contrib

[CarolEidt]

I haven't seen that behavior - I think the last time I ran PMI diffs was probably more than a week ago, though.

[kunalspathak]

Same here - I ran pmi with altjit yesterday and didn't see anything like that.

[sandreenko]

@CarolEidt @kunalspathak were you running pmi on tests?

[CarolEidt]

I usually just run it on frameworks and benchmarks (since it's kind of slow)

[sandreenko]

I usually just run it on frameworks and benchmarks (since it's kind of slow)

I see this issue only with tests, benchmarks and frameworks are passing for me as well.

Could you please try to run corerun pmi.dll PrepAll runtime\artifacts\tests\coreclr\Windows_NT.x64.Checked\JIT\Regression\CLR-x86-JIT\V1.2-Beta1\b210352\csharpgenerictypes\csharpgenerictypes.dll and see if it asserts for you or not?

[kunalspathak]

Could you please try to run corerun pmi.dll PrepAll runtime\artifacts\tests\coreclr\Windows_NT.x64.Checked\JIT\Regression\CLR-x86-JIT\V1.2-Beta1\b210352\csharpgenerictypes\csharpgenerictypes.dll and see if it asserts for you or not?

Worked for me.

[sandreenko]

Thanks Kunal, I will try to do a clean build/update jitutils and see if that fixes this for me.

[sandreenko]

Interesting, it is working for me with SHA that you gave me (10 days old), I will search when it stopped working, maybe my local changes.

[sandreenko]

Found the issue and probably a fix, it started to fail after #37745.