Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hardcoding wasm pinvoke paths #38278

Closed
Anipik opened this issue Jun 23, 2020 · 5 comments · Fixed by #35606
Closed

Remove Hardcoding wasm pinvoke paths #38278

Anipik opened this issue Jun 23, 2020 · 5 comments · Fixed by #35606
Assignees
@ViktorHofer
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation arch-wasm WebAssembly architecture area-Infrastructure-mono
Milestone
5.0.0

Comments

@Anipik
Copy link
Contributor

Anipik commented Jun 23, 2020

Currently We are hardcoding the pinvokes paths https://github.com/dotnet/runtime/blob/master/src/mono/wasm/wasm.targets#L12

The list is error pone and we should move away from it.

One was possible solutions suggested by @safern is adding p2ps and getting output assemblies.

cc @safern @ViktorHofer @ericstj
@Anipik Anipik added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Jun 23, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Jun 23, 2020
@ghost
Copy link

ghost commented Jun 23, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ericstj ericstj added arch-wasm WebAssembly architecture and removed untriaged New issue has not been triaged by the area owner labels Jun 23, 2020
@ericstj ericstj added this to the 5.0.0 milestone Jun 23, 2020
@ericstj
Copy link
Member

ericstj commented Jun 23, 2020

I would expect that this table should consider every assembly which is part of the runtimepack, is that right @akoeplinger?

This seems similar to some other things that @ViktorHofer has been working on.

@akoeplinger
Copy link
Member

Yes it should consider every assembly.

@safern
Copy link
Member

safern commented Jun 23, 2020

Yeah I agree we should consider every assembly instead of hard coding a list of assets.

@ghost
Copy link

ghost commented Jul 21, 2020

Tagging subscribers to this area: @directhex
Notify danmosemsft if you want to be subscribed.

@ViktorHofer ViktorHofer self-assigned this Jul 21, 2020
@ViktorHofer ViktorHofer mentioned this issue Jul 21, 2020
Merged
3 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ViktorHofer ViktorHofer

Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Remove depprojs in favor of PackageReferences ViktorHofer/runtime
6 participants
@akoeplinger @ViktorHofer @ericstj @Anipik @safern @Dotnet-GitSync-Bot