Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dotnet pack on libraries projects #37960

Closed
ViktorHofer opened this issue Jun 16, 2020 · 2 comments · Fixed by #40107
Closed

Support dotnet pack on libraries projects #37960

ViktorHofer opened this issue Jun 16, 2020 · 2 comments · Fixed by #40107

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 16, 2020

dotnet pack currently does nothing when invoked on an library project. We should be able to route dotnet pack invoked on the source project to the pkgproj and invoke its build target.

In addition to that it would be nice if the pkgproj build output doesn't point to the nuspec but to the nupkg instead (same what NuGet does). //update: already done by @ericstj: dotnet/arcade@b0b76b6

Long term, we should consider getting rid of pkgprojs and enable dotnet pack natively on our source projects. This probably involves extending the existing NuGet infrastructure, presumably with a new msbuild sdk similar to the existing Microsoft.DotNet.Build.Tasks.Packaging infra package. Related: dotnet/arcade#1033

See #37961 for exposing a single entry point for generating the library package.

cc @joperezr @ericstj @Anipik

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Jun 16, 2020
@ghost
Copy link

ghost commented Jun 16, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@Anipik Anipik added this to the Future milestone Jun 24, 2020
@ViktorHofer
Copy link
Member Author

This will help make packaging easier, i.e. #28244

@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Jul 8, 2020
@ViktorHofer ViktorHofer self-assigned this Jul 29, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants