Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NativeCallableAttribute to UnmanagedCallersOnlyAttribute #35433

Closed
3 tasks done
AaronRobinsonMSFT opened this issue Apr 25, 2020 · 0 comments · Fixed by #35592
Closed
3 tasks done

Rename NativeCallableAttribute to UnmanagedCallersOnlyAttribute #35433

AaronRobinsonMSFT opened this issue Apr 25, 2020 · 0 comments · Fixed by #35592
Assignees
@AaronRobinsonMSFT
Labels
area-Interop-coreclr
Milestone
5.0.0

Comments

@AaronRobinsonMSFT
Copy link
Member

AaronRobinsonMSFT commented Apr 25, 2020 •
edited
Loading

The NativeCallableAttribute was recently made public. During subsequent C# function pointer discussions it was mentioned the naming of the attribute is inconsistent with the C# function pointer proposal. It has been decided to rename the attribute to UnmanagedCallersOnlyAttribute.

The intent here is to align with the C# function pointers usage of the unmanaged contextual identifier.

The following should be performed:

  • Update official API and ref assembly.
  • Update test usage.
  • Update various places in runtime source to align with rename.

/cc @jkoritzinsky @elinor-fung
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 5.0 milestone Apr 25, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 25, 2020
@AaronRobinsonMSFT AaronRobinsonMSFT removed the untriaged New issue has not been triaged by the area owner label Apr 25, 2020
@jkotas jkotas mentioned this issue Apr 26, 2020
Open
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this issue Apr 27, 2020
Closed
@AaronRobinsonMSFT AaronRobinsonMSFT self-assigned this Apr 28, 2020
This was referenced Apr 29, 2020
Merged
Closed
This was referenced Apr 29, 2020
Closed
Closed
@jkotas jkotas mentioned this issue Jun 3, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-Interop-coreclr
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

NativeCallableAttribute to UnmanagedCallersOnlyAttribute AaronRobinsonMSFT/runtime
2 participants
@AaronRobinsonMSFT @Dotnet-GitSync-Bot