Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should AllowReversePInvokeCallsAttribute be marked Obsolete? #34701

Closed
AaronRobinsonMSFT opened this issue Apr 8, 2020 · 3 comments · Fixed by #39636
Closed

Should AllowReversePInvokeCallsAttribute be marked Obsolete? #34701

AaronRobinsonMSFT opened this issue Apr 8, 2020 · 3 comments · Fixed by #39636
Labels
area-System.Runtime.InteropServices
Milestone
5.0.0

Comments

@AaronRobinsonMSFT
Copy link
Member

Should AllowReversePInvokeCallsAttribute be marked Obsolete and point to NativeCallableAttribute? This appears to be a legacy attribute with no real application anymore.

/cc @jkotas @stephentoub
@AaronRobinsonMSFT AaronRobinsonMSFT added area-System.Runtime.InteropServices untriaged New issue has not been triaged by the area owner labels Apr 8, 2020
@jkotas
Copy link
Member

jkotas commented Apr 8, 2020

This attribute is part of code access security (CAS) family of attributes. It should be on the same plan as the rest of them.

We should mark all CAS attributes as obsolete once we have the fine grained controls for obsoleting in place (#31279 (comment)).

@jkoritzinsky
Copy link
Member

I believe the fine grained obsoletion support is merged in and supported in Roslyn.

@jeffschwMSFT jeffschwMSFT added this to the 5.0 milestone Apr 9, 2020
@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Apr 9, 2020
@AaronRobinsonMSFT
Copy link
Member Author

This can be addressed by following the pattern in #37536.

@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this issue Jul 20, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Declare AllowReversePInvokeCallsAttribute as Obsolete. AaronRobinsonMSFT/runtime
4 participants
@jkoritzinsky @jkotas @jeffschwMSFT @AaronRobinsonMSFT