Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate caching the underlying internal converters like KeyValuePairConverter #32352

Closed
ahsonkhan opened this issue Feb 15, 2020 · 1 comment
Closed

Investigate caching the underlying internal converters like KeyValuePairConverter #32352

ahsonkhan opened this issue Feb 15, 2020 · 1 comment
Labels
area-System.Text.Json tenet-performance Performance related issue
Milestone
5.0.0

Comments

@ahsonkhan
Copy link
Contributor

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/KeyValuePairConverter.cs

Lines 18 to 20 in d4b06b1

// todo: it is possible to cache the underlying converters since this is an internal converter and
// an instance is created only once for each JsonSerializerOptions instance.

cc @steveharter
@ahsonkhan ahsonkhan added this to the 5.0 milestone Feb 15, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 15, 2020
@ahsonkhan ahsonkhan removed the untriaged New issue has not been triaged by the area owner label Feb 15, 2020
@ahsonkhan ahsonkhan mentioned this issue Feb 15, 2020
Merged
@layomia
Copy link
Contributor

layomia commented Apr 7, 2020

Duplicate of #32148.

@layomia layomia closed this as completed Apr 7, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Text.Json tenet-performance Performance related issue
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@ahsonkhan @layomia @Dotnet-GitSync-Bot