Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdditionalBuildTargetFrameworks should include .NET Framework TargetFrameworks #31872

Closed
ViktorHofer opened this issue Feb 6, 2020 · 2 comments · Fixed by #35606
Closed

AdditionalBuildTargetFrameworks should include .NET Framework TargetFrameworks #31872

ViktorHofer opened this issue Feb 6, 2020 · 2 comments · Fixed by #35606

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 6, 2020

However, you can build for more TargetFrameworks by setting AdditionalBuildTargetFrameworks property.

(from #31823)

Can we change the config system so that .NET Framework TFMs - if set in the project - are built as well, IF the tooling to build is already restored? I don't see a reason why we would filter them out if the vertical is already restored.

This would make it easier to build and run tests on .NET Framework configurations.

cc @Anipik @ericstj @safern

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 6, 2020
@ViktorHofer ViktorHofer added discussion and removed untriaged New issue has not been triaged by the area owner labels Feb 6, 2020
@ericstj
Copy link
Member

ericstj commented Feb 6, 2020

Downside of this is that we currently require refpaths for this to work. To get those you need to build the netfx vertical or allconfigurations. I'm more inclined to just fix #31844, then make VS build behave same as SDK (all configurations).

@ViktorHofer
Copy link
Member Author

then make VS build behave same as SDK (all configurations).

What if we change the default not just for VS so that a dotnet build on an individual projects builds all configurations as well? That would be the expected behavior that you get from the sdk by default.

@Anipik Anipik added this to the Future milestone Jul 8, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants