Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up target defines in JIT #31732

Closed
CarolEidt opened this issue Feb 4, 2020 · 0 comments · Fixed by #31740
Closed

Clean up target defines in JIT #31732

CarolEidt opened this issue Feb 4, 2020 · 0 comments · Fixed by #31740
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Comments

@CarolEidt
Copy link
Contributor

There are a number of inconsistencies in the use of the target defines in the JIT. Some are remnants from #2256 which didn't rename the use of the macros in comments, and some are pre-existing (and of more concern).

These look like actual mistakes/bugs:

  • optcse.cpp: #elif _TARGET_ARM32
  • gentree.cpp: #if defined(_TARGET_XARCH4_) && defined(FEATURE_HW_INTRINSICS) (this just protects a bunch of asserts)

Occurrences of these in comments should be cleaned up :

  • Rename _TARGET_xxx_ or _TARGET_xxx to TARGET_xxx (note that there are a few _TARGET_xxx without the trailing _ in comments)
@CarolEidt CarolEidt added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 4, 2020
@CarolEidt CarolEidt mentioned this issue Feb 4, 2020
Merged
@sdmaclea sdmaclea mentioned this issue Feb 4, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JIT TARGET usage sdmaclea/runtime
1 participant
@CarolEidt