Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multi-segment Utf8JsonReader test coverage for ReadOnlySequence #27949

Closed
ahsonkhan opened this issue Nov 19, 2018 · 4 comments
Closed

Improve multi-segment Utf8JsonReader test coverage for ReadOnlySequence #27949

ahsonkhan opened this issue Nov 19, 2018 · 4 comments
Labels
area-System.Text.Json backlog-cleanup-candidate An inactive issue that has been marked for automated closure. help wanted [up-for-grabs] Good issue for external contributors increase-code-coverage Tracking need to add more test and increase code coverage of a component test-enhancement Improvements of test source code
Milestone
Future

Comments

@ahsonkhan
Copy link
Member

In particular:

  • Add more tests for various sequence segment sizes with invalid JSON.
  • Add tests with valid comments that can be skipped or allowed.

Borrow the tests for the span-based Utf8JsonReader as a starting point.

Multi-segment support added here: dotnet/corefx#33462
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@marcusturewicz
Copy link
Contributor

I'd like to take this one. What sequence sizes should I use? And could you elaborate on the second point about comments?

@ghost
Copy link

ghost commented Oct 15, 2021

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of the experimental issue cleanup initiative we are currently trialing in a limited number of areas. Please share any feedback you might have in the linked issue.

@GSPP
Copy link

GSPP commented Oct 21, 2021

@eiriktsarpalis found another one from this series of issues.

@ghost ghost removed the no-recent-activity label Oct 21, 2021
@eiriktsarpalis eiriktsarpalis mentioned this issue Oct 21, 2021
Open
@eiriktsarpalis
Copy link
Member

I'd be inclined to close this as a duplicate of #30706 and #30751, since they define more actionable test cases to be incorporated.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2021
@eiriktsarpalis eiriktsarpalis added the backlog-cleanup-candidate An inactive issue that has been marked for automated closure. label Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Text.Json backlog-cleanup-candidate An inactive issue that has been marked for automated closure. help wanted [up-for-grabs] Good issue for external contributors increase-code-coverage Tracking need to add more test and increase code coverage of a component test-enhancement Improvements of test source code
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@eiriktsarpalis @ahsonkhan @msftgits @GSPP @marcusturewicz