Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetCore package description commit hash could use some explanation? #24074

Closed
rrelyea opened this issue Nov 7, 2017 · 5 comments
Closed

NetCore package description commit hash could use some explanation? #24074

rrelyea opened this issue Nov 7, 2017 · 5 comments
Labels
area-Infrastructure-libraries enhancement Product code improvement that does NOT require public API changes/additions packaging Related to packaging
Milestone

Comments

@rrelyea
Copy link
Contributor

rrelyea commented Nov 7, 2017

Microsoft.NETCore.App has the following description in its nuspec:

    <description>A set of .NET API's that are included in the default .NET Core application model. 
e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d 
When using NuGet 3.x this package requires at least version 3.4.</description>

I just got a question asking if this was a NuGet.org or NuGet client bug...

Perhaps changing that to something like the following would make it more helpful to more people?

    <description>A set of .NET API's that are included in the default .NET Core application model. 
Commit hash: e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d 
When using NuGet 3.x this package requires at least version 3.4.</description>
@wtgodbe wtgodbe self-assigned this Dec 28, 2018
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@wtgodbe wtgodbe removed their assignment Feb 3, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Jun 23, 2020
@ViktorHofer
Copy link
Member

@ericstj do you know where we set the Commit SHA?

@ericstj
Copy link
Member

ericstj commented Oct 5, 2020

It's done here: https://github.com/dotnet/arcade/blob/988d74184dc8069591a80b0a58ba6f7af79afcc9/src/Microsoft.DotNet.Build.Tasks.Packaging/src/build/Packaging.targets#L889

Perhaps now that we embed the actual source control info in the packages via NuGet's https://docs.microsoft.com/en-us/nuget/reference/nuspec#repository we can just remove this. The former pre-dates the latter.

@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 5, 2020

Sounds like a plan. Maybe you have a few "minutes" sometime to remove that code/infra? (panda face)

@ericstj
Copy link
Member

ericstj commented Oct 5, 2020

Let's add it to pkgproj epic, there could be nuance to removal. Would be better to just leave it behind in the refactor.

@ViktorHofer
Copy link
Member

ViktorHofer commented Dec 28, 2020

The commit SHA got removed from the packages and it's now part of the nuspec and displayed via nuget.org or NuGet Package Explorer.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries enhancement Product code improvement that does NOT require public API changes/additions packaging Related to packaging
Projects
None yet
Development

No branches or pull requests

6 participants