Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw PNSE for Process.Modules and Process.MainModule in UWP #22567

Closed
danmoseley opened this issue Jun 29, 2017 · 4 comments
Closed

Throw PNSE for Process.Modules and Process.MainModule in UWP #22567

danmoseley opened this issue Jun 29, 2017 · 4 comments

Comments

@danmoseley
Copy link
Member

We cannot use K32EnumProcessModules in UWP as it's not on the approved list.

It’s used by Process.Modules and Process.MainModule -- usage is low and there's workarounds so just throw PNSE for those in UWP only.

@danmoseley
Copy link
Member Author

@sepidehms

@danmoseley
Copy link
Member Author

then delete from src\System.Diagnostics.Process\src\PinvokeAnalyzerExceptionList.analyzerdata.uap

@stephentoub
Copy link
Member

so just throw PNSE for those in UWP only.

Rather than throwing, can we do something like what we do on macOS?
https://github.com/dotnet/corefx/blob/master/src/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.OSX.cs#L107-L110

@danmoseley
Copy link
Member Author

Sounds good to me. The usage for MainModule is about 5x higher than Modules.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the UWP6.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants