Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Microsoft.VisualBasic tests on UapAot #22542

Closed
joperezr opened this issue Jun 28, 2017 · 2 comments · Fixed by dotnet/corefx#22121
Closed

Fix Microsoft.VisualBasic tests on UapAot #22542

joperezr opened this issue Jun 28, 2017 · 2 comments · Fixed by dotnet/corefx#22121
Labels
area-Microsoft.VisualBasic
Milestone
UWP6.0

Comments

@joperezr
Copy link
Member

Some new tests were added recently which are not working in uapaot. This issue is to track the work of investigating, fixing and enabling (the ones that should be re-enabled) them.

FYI: @hughbe who recently added them.
@danmoseley
Copy link
Member

dotnet/corefx#21683

@tijoytom-zz tijoytom-zz assigned ghost Jul 5, 2017
@tijoytom-zz
Copy link
Contributor

@atsushikan Can you please take quick look ?
@joshfree

stephentoub referenced this issue in dotnet/corefx Jul 6, 2017
@atsushikan @stephentoub
Reactivate Microsoft.VisualBasic ILC tests that are no longer failing. (
7dff34f 
#21939)

Most of https://github.com/dotnet/corefx/issues/21682

Isolated the one remaining failure - will keep using issue
to track.
stephentoub referenced this issue in dotnet/corefx Jul 12, 2017
@atsushikan @stephentoub
Reeenable VisualBasic test on ILC. (#22121)
d841654 
The underlying codegen bug has been fixed.

Fixes https://github.com/dotnet/corefx/issues/21682
pjanotti referenced this issue in pjanotti/corefx Jul 20, 2017
@atsushikan
Reeenable VisualBasic test on ILC. (dotnet#22121)
f57846e 
The underlying codegen bug has been fixed.

Fixes https://github.com/dotnet/corefx/issues/21682
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the UWP6.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Microsoft.VisualBasic
Projects
None yet
Milestone
UWP6.0
Development

Successfully merging a pull request may close this issue.

Reeenable VisualBasic test on ILC.
4 participants
@tijoytom-zz @danmoseley @msftgits @joperezr