Test failure: System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest/BasicTest_AccessInstanceProperties_NoExceptions_Linux #18090
Comments
|
@ericeil I'm seeing this in some Ubuntu 16.10 runs as well. I'm pretty sure that the only way this could happen is if the actual statistics file from the system (/sys/class/net//speed) actually contains "-1" instead of a real speed value. I think we should just return |
|
Failing constantly again. Reopening. |
|
It fails on |
|
Hit on #2098 |
|
Another tracking issue for this: #32179 |
|
Not sure why my GitHub search didn't turn up this issue. Closing #32179 and using this as the primary. Will bring the test failure table over here. |
|
As a part of actually fixing this bug I think we need to do a root cause investigation here given the wide scale impact of this break. It essentially took down all builds for quite a long period of time. |
davidsh
added
the
disabled-test
|
A bsd version of this test System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest.BasicTest_AccessInstanceProperties_NoExceptions_bsd fails in dotnet/corefx#42850 This in 3.1 branch |
no, I don't. At least for the OSX failures, it feels like something changes with the infrastructure. Since loopback should not really have speed, I would expect this to be -1. |
|
actually, never mind. I look at the wrong part @ManickaP. We should capture the output of Fox OSX we should get output of |
|
So I added the For instance in: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-32223-merge-389ed0c11d0c4fedb6/System.Net.NetworkInformation.Functional.Tests/console.ec529df2.log?sv=2019-02-02&se=2020-02-23T13%3A17%3A47Z&sr=c&sp=rl&sig=keU1SXAgQX57de4XmOeEL%2FT5IO9iN7xD%2BuOE7LwtZu0%3D. More can be found in the failed tests of this WIP PR #32223. The problem isn't in the cast, but in the multiplying by 1 000 000 in here: https://github.com/dotnet/runtime/blob/master/src/libraries/Native/Unix/System.Native/pal_interfaceaddresses.c#L380 |
|
Good find @ManickaP. Probably time to bump it to |
I'm already running tests in my PR for this fix. |
|
@ManickaP thanks for tracking this down! |
Fixes #18090 Linux pal level struct for network info had only int32 field for speed. Even though our public API has it as long. The problem was in value overflowing in calculation MBits --> Bits.
ghost
locked as resolved and limited conversation to collaborators
Opened on behalf of @jiangzeng
The test
System.Net.NetworkInformation.Tests.NetworkInterfaceBasicTest/BasicTest_AccessInstanceProperties_NoExceptions_Linuxhas failed.Stack Trace:
Failing configurations:
The text was updated successfully, but these errors were encountered: