Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional work in dumpasync command #11243

Closed
stephentoub opened this issue Oct 16, 2018 · 5 comments
Closed

Additional work in dumpasync command #11243

stephentoub opened this issue Oct 16, 2018 · 5 comments

Comments

@stephentoub
Copy link
Member

In dotnet/coreclr#18160 and dotnet/coreclr#18213 for 3.0 we added a basic dumpasync command to SOS. Before we actually ship it, we should try to augment it in a few ways:

  1. Remove the dependency on interpreting the C# state machine's _state field. We can use the Task's IsCompleted for the same purpose.
  2. Add support for following continuation chains. Right now we use gcroots for this purpose, which can actually be more comprehensive, but also adds a lot of runtime expense.
  3. Support optionally finding all Tasks, not just async state machine objects; that's fairly easily done with dumpheap today, but the gcroot automation, completion detection, and continuation-chain following from (2) all make it much more useful in dumpasync than it is in dumpheap.
  4. List all thread stacks waiting on tasks, and dump the associated information for that task (state machine if it's an async method, gcroot / continuation chain, etc.)

cc: @noahfalk

@mikem8361
Copy link
Member

Maybe this could be done in the diagnostics repo.

@stephentoub
Copy link
Member Author

Is that the official home now for the SOS source? Is the code in coreclr being deleted then? Or mirrored? Or some such thing?

@mikem8361
Copy link
Member

mikem8361 commented Oct 16, 2018 via email

@tommcdon
Copy link
Member

@mikem8361 can we move this issue to the diagnostics repo?

@mikem8361
Copy link
Member

Issue moved to dotnet/diagnostics dotnet/coreclr#163 via ZenHub

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants