Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Spurious 0-sized diffs in smoke_tests.nativeaot.windows.arm64 #104441

Closed
jakobbotsch opened this issue Jul 4, 2024 · 4 comments · Fixed by #105522
Closed

JIT: Spurious 0-sized diffs in smoke_tests.nativeaot.windows.arm64 #104441

jakobbotsch opened this issue Jul 4, 2024 · 4 comments · Fixed by #105522
Assignees
@kunalspathak
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
9.0.0

Comments

@jakobbotsch
Copy link
Member

We're seeing some spurious 0-sized diffs in smoke_tests.nativeaot.windows.arm64. Seems likely to be related to #104282, can you take a look @kunalspathak?
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 4, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch jakobbotsch mentioned this issue Jul 4, 2024
Merged
@kunalspathak
Copy link
Member

Most likely the new relocations are not getting recorded properly, will take a look

@kunalspathak kunalspathak self-assigned this Jul 4, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Jul 5, 2024
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Jul 5, 2024
@VSadov VSadov mentioned this issue Jul 6, 2024
Closed
@kunalspathak kunalspathak mentioned this issue Jul 7, 2024
Merged
@jakobbotsch jakobbotsch mentioned this issue Jul 9, 2024
Closed
@jakobbotsch
Copy link
Member Author

@kunalspathak #104516 does not seem to have fixed this issue -- I still see 0 sized diffs on superpmi-diffs in smoke_tests.nativeaot.windows.arm64.checked.

@kunalspathak
Copy link
Member

kunalspathak commented Jul 22, 2024 •
edited
Loading

@kunalspathak #104516 does not seem to have fixed this issue -- I still see 0 sized diffs on superpmi-diffs in smoke_tests.nativeaot.windows.arm64.checked.

Yes, the fix in #104516 was mainly for handling the "unhandled reloc type" errors and not this specific one. I was not able to setup libcoredistools to debug what the problem is. Will send separate fix for this one.

Edit: Just saw that I tagged this issue to the PR, which should have not been the case. Removed the tagging from the PR.

@kunalspathak kunalspathak mentioned this issue Jul 25, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Skip reloc handling for IMAGE_REL_BASED_DIR64 if already handled kunalspathak/runtime
3 participants
@jakobbotsch @kunalspathak @JulieLeeMSFT