Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default #102906

Closed
stephentoub opened this issue May 31, 2024 · 1 comment · Fixed by #104202
Closed

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default #102906

stephentoub opened this issue May 31, 2024 · 1 comment · Fixed by #104202
Assignees
@stephentoub
Labels
area-System.Runtime in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@stephentoub
Copy link
Member

As part of #27229, we want all the relevant comparers for strings to implement IAlternateEqualityComparer<ReadOnlySpan<char>, string>. The initial implementation does so for all of the StringComparer singletons, but not for EqualityComparer<string>.Default. This means that the alternate lookup support for spans on dictionaries/sets will only work when those collections are explicitly given a supported comparer. This issue tracks implementing the interface on the default comparer for string, as well.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 31, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 31, 2024
@stephentoub stephentoub added area-System.Runtime and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 31, 2024
@stephentoub stephentoub added this to the 9.0.0 milestone May 31, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

@stephentoub stephentoub mentioned this issue May 31, 2024
Merged
@stephentoub stephentoub modified the milestones: 9.0.0, Future Jun 8, 2024
@stephentoub stephentoub mentioned this issue Jun 10, 2024
Merged
@stephentoub stephentoub self-assigned this Jun 29, 2024
@stephentoub stephentoub modified the milestones: Future, 9.0.0 Jun 30, 2024
@stephentoub stephentoub mentioned this issue Jun 30, 2024
Merged
@stephentoub stephentoub added the in-pr There is an active PR which will close this issue when it is merged label Jul 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stephentoub stephentoub

Labels
area-System.Runtime in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
9.0.0
1 participant
@stephentoub