-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we avoid resetting all env vars for some remotely executed tests? #100505
Comments
Also blocks various testing modes: gcstress, jitstress, SPMI collection, etc. |
For the |
@BruceForstall pointed me at this, which seems like a good pattern to emulate: Lines 182 to 195 in 4039b45
There are only 6 hits for |
I think both these patterns are questionable. In both of these cases, the code wants to clear or preserve environment variables that affect process globalization settings. The code should clear the specific environment variables - it is a small finite number - and leave everything else intact. It would be nice to factor this out into a helpers under src\libraries\Common so that we have just one place to update if we discover new environment variables that affect globalization. |
Can somebody help me figure out what needs to be cleared? |
I think clearing |
Still want to do this, but not a must-have for 9.0 |
The environment clearing done here:
runtime/src/libraries/System.Memory/tests/Span/StringSearchValues.cs
Lines 554 to 563 in 4039b45
(and likely elsewhere) makes impossible to tunnel
DOTNET
options through the test layers to enable various JIT diagnostics and debugging techniques.cc @MihaZupan @dotnet/jit-contrib
The text was updated successfully, but these errors were encountered: