From c803601b7887a9d0b76ac17928f02c9d601d315a Mon Sep 17 00:00:00 2001 From: Elinor Fung Date: Wed, 3 Jun 2020 11:55:01 -0700 Subject: [PATCH] PR feedback --- src/coreclr/src/vm/jitinterface.cpp | 2 +- src/coreclr/src/vm/methodtable.h | 2 +- src/coreclr/src/vm/prestub.cpp | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/coreclr/src/vm/jitinterface.cpp b/src/coreclr/src/vm/jitinterface.cpp index 80c5e51cf06f7..4574daca8e295 100644 --- a/src/coreclr/src/vm/jitinterface.cpp +++ b/src/coreclr/src/vm/jitinterface.cpp @@ -4501,7 +4501,7 @@ TypeCompareState CEEInfo::compareTypesForCast( else #endif // FEATURE_COMINTEROP - // If casting from ICastable, don't try to optimize + // If casting from ICastable or IDynamicInterfaceCastable, don't try to optimize if (fromHnd.GetMethodTable()->IsICastable() || fromHnd.GetMethodTable()->IsIDynamicInterfaceCastable()) { result = TypeCompareState::May; diff --git a/src/coreclr/src/vm/methodtable.h b/src/coreclr/src/vm/methodtable.h index 37e71c603bbab..76d390ed5282d 100644 --- a/src/coreclr/src/vm/methodtable.h +++ b/src/coreclr/src/vm/methodtable.h @@ -3601,7 +3601,7 @@ public : enum_flag_HasFinalizer = 0x00100000, // instances require finalization - enum_flag_IDynamicInterfaceCastable = 0x00200000, // class implements IDynamicInterfaceCastable interface + enum_flag_IDynamicInterfaceCastable = 0x00200000, // class implements IDynamicInterfaceCastable interface enum_flag_ICastable = 0x00400000, // class implements ICastable interface diff --git a/src/coreclr/src/vm/prestub.cpp b/src/coreclr/src/vm/prestub.cpp index d5fe996cd5d33..8922590fed932 100644 --- a/src/coreclr/src/vm/prestub.cpp +++ b/src/coreclr/src/vm/prestub.cpp @@ -1907,7 +1907,6 @@ extern "C" PCODE STDCALL PreStubWorker(TransitionBlock* pTransitionBlock, Method { pDispatchingMT = curobj->GetMethodTable(); - if (pDispatchingMT->IsICastable() || pDispatchingMT->IsIDynamicInterfaceCastable()) { MethodTable* pMDMT = pMD->GetMethodTable();