diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs index 19b1df66a1545e..a2d77ef28b3eec 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs @@ -601,14 +601,18 @@ public void TestMaxWorkingSet() } } + // XXX No longer skip: OSX, FreeBSD [Fact] - [SkipOnPlatform(TestPlatforms.OSX | TestPlatforms.FreeBSD | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Getting MaxWorkingSet is not supported on OSX, BSD, iOS, MacCatalyst, and tvOS.")] + [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Getting MaxWorkingSet is not supported on OSX, BSD, iOS, MacCatalyst, and tvOS.")] public void MaxWorkingSet_GetNotStarted_ThrowsInvalidOperationException() { var process = new Process(); Assert.Throws(() => process.MaxWorkingSet); } +#if 0 // XXX This appears to be testing for incorrect behavoir which has been fixed. + // XXX See https://github.com/dotnet/runtime/issues/105422 + // The correct exception for a new process is: InvalidOperationException [Fact] [PlatformSpecific(TestPlatforms.OSX | TestPlatforms.FreeBSD)] public void MaxValueWorkingSet_GetSetMacos_ThrowsPlatformSupportedException() @@ -617,6 +621,7 @@ public void MaxValueWorkingSet_GetSetMacos_ThrowsPlatformSupportedException() Assert.Throws(() => process.MaxWorkingSet); Assert.Throws(() => process.MaxWorkingSet = (IntPtr)1); } +#endif [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] public void TestMinWorkingSet() @@ -656,14 +661,18 @@ public void TestMinWorkingSet() } } + // XXX No longer skip: OSX, FreeBSD [Fact] - [SkipOnPlatform(TestPlatforms.OSX | TestPlatforms.FreeBSD | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Getting MinWorkingSet is not supported on OSX, BSD, iOS, MacCatalyst, and tvOS.")] + [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Getting MinWorkingSet is not supported on OSX, BSD, iOS, MacCatalyst, and tvOS.")] public void MinWorkingSet_GetNotStarted_ThrowsInvalidOperationException() { var process = new Process(); Assert.Throws(() => process.MinWorkingSet); } +#if 0 // XXX This appears to be testing for incorrect behavoir which has been fixed. + // XXX See https://github.com/dotnet/runtime/issues/105422 + // The correct exception for a new process is: InvalidOperationException [Fact] [PlatformSpecific(TestPlatforms.OSX | TestPlatforms.FreeBSD)] public void MinWorkingSet_GetMacos_ThrowsPlatformSupportedException() @@ -671,6 +680,7 @@ public void MinWorkingSet_GetMacos_ThrowsPlatformSupportedException() var process = new Process(); Assert.Throws(() => process.MinWorkingSet); } +#endif [Fact] public void TestModules()