-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Always fire join events for an rjoin (#651)
Previously, there was an additional check `if (!join_struct.wait_done)` at the beginning of an rjoin. This usually had no effect as the join isn't usually done yet. But if thread A is the first to enter the join and finishes before thread B starts, then B will never enter the `if`. The only effect this had was that B would not fire join events in these rare cases. (After that we check `join_struct.wait_done` again anyway.) As of this PR we will always fire the events, which makes them easier to analyze consistently. Before this PR, looking at the join events for a single thread would show no traces of the rjoin happening, except for an extra restart event from the other thread.
- Loading branch information
Andy Hanson
committed
Feb 7, 2020
1 parent
7814f97
commit 1275e5f
Showing
1 changed file
with
30 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters