-
Notifications
You must be signed in to change notification settings - Fork 4.7k
/
NamedPipeTest.CurrentUserOnly.Windows.cs
242 lines (213 loc) · 11.3 KB
/
NamedPipeTest.CurrentUserOnly.Windows.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
using Microsoft.Win32.SafeHandles;
using System.ComponentModel;
using System.DirectoryServices.AccountManagement;
using System.Runtime.InteropServices;
using System.Security.Cryptography;
using System.Security.Principal;
using System.Threading;
using System.Threading.Tasks;
using Xunit;
namespace System.IO.Pipes.Tests
{
// Class to be used as xUnit fixture to avoid creating the user, an relatively slow operation (couple of seconds), multiple times.
public class TestAccountImpersonator : IDisposable
{
private const string TestAccountName = "CorFxTst0uZa"; // Random suffix to avoid matching any other account by accident, but const to avoid leaking it.
private SafeAccessTokenHandle _testAccountTokenHandle;
public TestAccountImpersonator()
{
string testAccountPassword;
byte[] randomBytes = RandomNumberGenerator.GetBytes(33);
// Add special chars to ensure it satisfies password requirements.
testAccountPassword = Convert.ToBase64String(randomBytes) + "_-As@!%*(1)4#2";
DateTime accountExpirationDate = DateTime.UtcNow + TimeSpan.FromMinutes(2);
using (var principalCtx = new PrincipalContext(ContextType.Machine))
{
bool needToCreate = false;
using (var foundUserPrincipal = UserPrincipal.FindByIdentity(principalCtx, TestAccountName))
{
if (foundUserPrincipal == null)
{
needToCreate = true;
}
else
{
// Somehow the account leaked from previous runs, however, password is lost, reset it.
foundUserPrincipal.SetPassword(testAccountPassword);
foundUserPrincipal.AccountExpirationDate = accountExpirationDate;
foundUserPrincipal.Save();
}
}
if (needToCreate)
{
using (var userPrincipal = new UserPrincipal(principalCtx))
{
userPrincipal.SetPassword(testAccountPassword);
userPrincipal.AccountExpirationDate = accountExpirationDate;
userPrincipal.Name = TestAccountName;
userPrincipal.DisplayName = TestAccountName;
userPrincipal.Description = TestAccountName;
userPrincipal.Save();
}
}
}
const int LOGON32_PROVIDER_DEFAULT = 0;
const int LOGON32_LOGON_INTERACTIVE = 2;
if (!LogonUser(TestAccountName, ".", testAccountPassword, LOGON32_LOGON_INTERACTIVE, LOGON32_PROVIDER_DEFAULT, out _testAccountTokenHandle))
{
_testAccountTokenHandle = null;
throw new Exception($"Failed to get SafeAccessTokenHandle for test account {TestAccountName}", new Win32Exception());
}
}
public void Dispose()
{
if (_testAccountTokenHandle == null)
return;
_testAccountTokenHandle.Dispose();
_testAccountTokenHandle = null;
using (var principalCtx = new PrincipalContext(ContextType.Machine))
using (var userPrincipal = UserPrincipal.FindByIdentity(principalCtx, TestAccountName))
{
if (userPrincipal == null)
throw new Exception($"Failed to get user principal to delete test account {TestAccountName}");
try
{
userPrincipal.Delete();
}
catch (InvalidOperationException)
{
// TODO: Investigate, it always throw this exception with "Can't delete object already deleted", but it actually deletes it.
}
}
}
// This method asserts if it impersonates the current identity, i.e.: it ensures that an actual impersonation happens
public void RunImpersonated(Action action)
{
using (WindowsIdentity serverIdentity = WindowsIdentity.GetCurrent())
{
WindowsIdentity.RunImpersonated(_testAccountTokenHandle, () =>
{
using WindowsIdentity clientIdentity = WindowsIdentity.GetCurrent();
Assert.NotEqual(serverIdentity.Name, clientIdentity.Name);
Assert.False(new WindowsPrincipal(clientIdentity).IsInRole(WindowsBuiltInRole.Administrator));
action();
});
}
}
[DllImport("advapi32.dll", SetLastError = true, CharSet = CharSet.Unicode)]
private static extern bool LogonUser(string userName, string domain, string password, int logonType, int logonProvider, out SafeAccessTokenHandle safeAccessTokenHandle);
}
/// <summary>
/// Negative tests for PipeOptions.CurrentUserOnly in Windows.
/// </summary>
public class NamedPipeTest_CurrentUserOnly_Windows : IClassFixture<TestAccountImpersonator>
{
public static bool IsSupportedWindowsVersionAndPrivilegedProcess => PlatformDetection.IsPrivilegedProcess
&& PlatformDetection.IsWindows
&& !PlatformDetection.IsWindows7
&& !PlatformDetection.IsWindowsNanoServer
&& !PlatformDetection.IsWindowsServerCore;
private TestAccountImpersonator _testAccountImpersonator;
public NamedPipeTest_CurrentUserOnly_Windows(TestAccountImpersonator testAccountImpersonator)
{
_testAccountImpersonator = testAccountImpersonator;
}
[OuterLoop("Requires admin privileges")]
[ConditionalFact(nameof(IsSupportedWindowsVersionAndPrivilegedProcess))]
public async Task Connection_UnderDifferentUsers_CurrentUserOnlyOnServer_InvalidClientConnectionAttempts_DoNotBlockSuccessfulClient()
{
string name = PipeStreamConformanceTests.GetUniquePipeName();
bool invalidClientShouldStop = false;
bool invalidClientIsRunning = false;
using var server = new NamedPipeServerStream(name, PipeDirection.InOut, 1, PipeTransmissionMode.Byte, PipeOptions.Asynchronous | PipeOptions.CurrentUserOnly);
Task serverWait = server.WaitForConnectionAsync();
Task invalidClient = Task.Run(() =>
{
// invalid non-current user tries to connect to server.
_testAccountImpersonator.RunImpersonated(() =>
{
while (!Volatile.Read(ref invalidClientShouldStop))
{
using var client = new NamedPipeClientStream(".", name, PipeDirection.In, PipeOptions.Asynchronous);
Assert.Throws<UnauthorizedAccessException>(() => client.Connect());
Volatile.Write(ref invalidClientIsRunning, true);
}
});
});
Assert.False(serverWait.IsCompleted);
while (!Volatile.Read(ref invalidClientIsRunning)) ; // Wait until the invalid client starts running.
// valid client tries to connect and succeeds.
using var client = new NamedPipeClientStream(".", name, PipeDirection.In, PipeOptions.Asynchronous);
client.Connect();
await serverWait;
Volatile.Write(ref invalidClientShouldStop, true);
}
[ConditionalTheory(nameof(IsSupportedWindowsVersionAndPrivilegedProcess))]
[InlineData(PipeOptions.None, PipeOptions.None, PipeDirection.InOut)] // Fails even without CurrentUserOnly, because under the default pipe ACL, other users are denied Write access, and client is requesting PipeDirection.InOut
[InlineData(PipeOptions.None, PipeOptions.CurrentUserOnly, PipeDirection.In)]
[InlineData(PipeOptions.None, PipeOptions.CurrentUserOnly, PipeDirection.InOut)]
[InlineData(PipeOptions.CurrentUserOnly, PipeOptions.None, PipeDirection.In)]
[InlineData(PipeOptions.CurrentUserOnly, PipeOptions.None, PipeDirection.InOut)]
[InlineData(PipeOptions.CurrentUserOnly, PipeOptions.CurrentUserOnly, PipeDirection.In)]
[InlineData(PipeOptions.CurrentUserOnly, PipeOptions.CurrentUserOnly, PipeDirection.InOut)]
public void Connection_UnderDifferentUsers_BehavesAsExpected(
PipeOptions serverPipeOptions, PipeOptions clientPipeOptions, PipeDirection clientDirection)
{
string name = PipeStreamConformanceTests.GetUniquePipeName();
using (var cts = new CancellationTokenSource())
using (var server = new NamedPipeServerStream(name, PipeDirection.InOut, 1, PipeTransmissionMode.Byte, serverPipeOptions | PipeOptions.Asynchronous))
{
Task serverTask = server.WaitForConnectionAsync(cts.Token);
_testAccountImpersonator.RunImpersonated(() =>
{
using (var client = new NamedPipeClientStream(".", name, clientDirection, clientPipeOptions))
{
Assert.Throws<UnauthorizedAccessException>(() => client.Connect());
}
});
if (serverPipeOptions == PipeOptions.None && clientPipeOptions == PipeOptions.CurrentUserOnly && clientDirection == PipeDirection.In)
{
// When CurrentUserOnly is only on client side and asks for ReadOnly access, the connection is not rejected
// but we get the UnauthorizedAccessException on the client regardless.
Assert.True(serverTask.IsCompletedSuccessfully);
}
else
{
// Server is expected to not have received any request.
cts.Cancel();
AggregateException ex = Assert.Throws<AggregateException>(() => serverTask.Wait(10_000));
Assert.IsType<TaskCanceledException>(ex.InnerException);
}
}
}
[ConditionalTheory(nameof(IsSupportedWindowsVersionAndPrivilegedProcess))]
[InlineData(false)]
[InlineData(true)]
public void Allow_Connection_UnderDifferentUsers_ForClientReading(bool useTimeSpan)
{
string name = PipeStreamConformanceTests.GetUniquePipeName();
using (var server = new NamedPipeServerStream(
name, PipeDirection.InOut, 1, PipeTransmissionMode.Byte, PipeOptions.Asynchronous))
{
Task serverTask = server.WaitForConnectionAsync(CancellationToken.None);
_testAccountImpersonator.RunImpersonated(() =>
{
using (var client = new NamedPipeClientStream(".", name, PipeDirection.In))
{
if (useTimeSpan)
{
client.Connect(TimeSpan.FromMilliseconds(10_000));
}
else
{
client.Connect(10_000);
}
}
});
Assert.True(serverTask.Wait(10_000));
}
}
}
}