Always make project changes using the 'batch scope' approach to reduce duplication. #74863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
approved these changes
Aug 22, 2024
| @@ -238,6 +239,8 @@ private void ChangeProjectProperty<T>( | |||
| Func<SolutionChangeAccumulator, ProjectUpdateState, T, ProjectUpdateState> updateSolution, | |||
| bool logThrowAwayTelemetry = false) | |||
| { | |||
| using var _ = CreateBatchScope(); | |||
There was a problem hiding this comment.
Looks like CreateBatchScope takes the semaphore inside. Any benefit of creating a CreateBatchScope_NoLock and moving it inside the gate we already take below?
There was a problem hiding this comment.
Talked offline. Def an option. Would prefer to see if we actually run into any contention that warrants this.
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #74858