Hook up file watchers for analyzer references #74858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Aug 22, 2024
| projectUpdateState = projectUpdateState.WithIncrementalAnalyzerReferencesRemoved(_analyzersRemovedInBatch); | ||
|
|
||
| foreach (var analyzerReference in _analyzersRemovedInBatch) | ||
| solutionChanges.UpdateSolutionForProjectAction(Id, solutionChanges.Solution.RemoveAnalyzerReference(Id, analyzerReference)); |
There was a problem hiding this comment.
doesn't look exactly the same as below as we don't hav ea Solution.RemoveAnalyzerReferences (plural) to go with Solution.AddAnalyzerReferences. And i'm not interested in adding that at this point :)
ToddGrun
reviewed
Aug 22, 2024
src/Workspaces/Core/Portable/Workspace/ProjectSystem/ProjectSystemProject.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Aug 22, 2024
src/Workspaces/Core/Portable/Workspace/ProjectSystem/ProjectSystemProject.cs
Show resolved
Hide resolved
|
@ToddGrun can you please takea nother look. @jasonmalinowski as well. |
CyrusNajmabadi
commented
Aug 22, 2024
| } | ||
|
|
||
| foreach (var mappedFullPath in mappedPaths) | ||
| if (_activeBatchScopes > 0) |
There was a problem hiding this comment.
i missed from this point downwards.
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #74745. This ensures the initial hookup happens to cause us to listen to file changes for analyzer references on disk.