Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry design time build fix while also keeping FUTDC working #74828

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

dibarbet
Copy link
Member

New version of #74822 that also should keep FUTDC working

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 20, 2024
@dibarbet dibarbet marked this pull request as ready for review August 20, 2024 22:32
@dibarbet dibarbet requested review from a team as code owners August 20, 2024 22:32
@@ -392,5 +392,8 @@
</ItemGroup>
</Target>

<!-- Workaround for an issue where nested targets (e.g. GetCopyToPublishDirectoryItems in the SDK) call _SplitProjectReferencesByFileExistence without calling implict prerequisite AssignProjectConfiguration -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a tracking bug for this?

@dibarbet dibarbet merged commit 7731e38 into dotnet:main Aug 21, 2024
28 checks passed
@dibarbet dibarbet deleted the designtimebuild_workaround branch August 21, 2024 20:39
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 21, 2024
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants