Clean inline rename session #74818
Merged
Clean inline rename session #74818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
Guess the best reviewer should be @ryzngard |
ryzngard
approved these changes
Aug 20, 2024
|
looking. |
CyrusNajmabadi
approved these changes
Aug 20, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few clean PRs before moving the commit operation to async.
This PR has no-effect on existing product behaviors..
Might be easier to review based on commit.
1. Remove the
CancellationTokenfromIInlineRenameSession.CommitAsync.IInlineRenameSessionalready containsvoid Cancel();to control all the cancellations. All the existing callers are call that method to cancel rename.In fact,
IInlineRenameSession.CommitAsyncnever accepts real cancellationToken from the caller.2. Let
InlineRenameSessionOptionsStorage.RenameAsynchronouslyto controlCommitAsync. (And it's on by default!!)This option exists for a long time, but things are never async. Only
ExtractMethodCommandHandleris callingCommitAsync(And it's calling JTF.Run)