Only copy devkit assemblies for unit tests when doing a real build #74812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
JoeRobich
approved these changes
Aug 19, 2024
dibarbet
force-pushed
the
fix_design_time_failure
branch
from
bb68d7f
to
94a37b6
Compare
|
@sharwell took your approach of putting it on the target |
dibarbet
force-pushed
the
fix_design_time_failure
branch
from
94a37b6
to
8b1bf32
Compare
Open
3 tasks
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the design time build was actually failing when it tried to copy these. We only need to copy them when running tests (whcih requires a real build) so skip it for design time builds. We do this in other places too (e.g. semantic search, build host, etc).
This doesn't seem to be related to the current missing project references failures however.
Resolves #74801