Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations in CSharpSyntaxFacts.AppendMembers (again) #74790

Merged
merged 6 commits into from
Aug 21, 2024

Remove method was using for testing

ed9cd83
Select commit
Loading
Failed to load commit list.
Merged

Reduce allocations in CSharpSyntaxFacts.AppendMembers (again) #74790

Remove method was using for testing
ed9cd83
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis succeeded Aug 20, 2024 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

Test Failures (2 tests failed)

🔹 [All failing tests from roslyn-integration-CI]

    ❌ Microsoft.CodeAnalysis.MSBuild.UnitTests.NewlyCreatedProjectsFromDotNetNew.ValidateVisualBasicTemplateProjects [Details] [1.84% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration
    Data Driven SubResults
      ❌ Microsoft.CodeAnalysis.MSBuild.UnitTests.NewlyCreatedProjectsFromDotNetNew.ValidateVisualBasicTemplateProjects(templateName: "xunit")
      Exception Message
      Expected 0 items but found 2: The following compiler diagnostics are being reported for the template.
Items:
    T:\RoslynTests\9a073728-4eaa-463e-b132-6dda93ffe777\UnitTest1.vb(2) : warning BC40056: Namespace or type specified in the Imports 'Xunit' doesn't contain any public member or cannot be found. Make sure the namespace or the type is defined and contains at least one public member. Make sure the imported element name doesn't use any aliases.
    T:\RoslynTests\9a073728-4eaa-463e-b132-6dda93ffe777\UnitTest1.vb(6) : error BC30002: Type 'Fact' is not defined.
      Stack Trace
         at Roslyn.Test.Utilities.AssertEx.Fail(String message) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 538
   at Roslyn.Test.Utilities.AssertEx.Empty[T](IEnumerable`1 items, String message) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 863
   at Microsoft.CodeAnalysis.MSBuild.UnitTests.NewlyCreatedProjectsFromDotNetNew.<AssertTemplateProjectLoadsCleanlyAsync>g__AssertProjectLoadsCleanlyAsync|12_3(String projectFilePath, String[] ignoredDiagnostics) in /_/src/Workspaces/MSBuildTest/NewlyCreatedProjectsFromDotNetNew.cs:line 245
   at Microsoft.CodeAnalysis.MSBuild.UnitTests.NewlyCreatedProjectsFromDotNetNew.AssertTemplateProjectLoadsCleanlyAsync(String templateName, String languageName, String[] ignoredDiagnostics) in /_/src/Workspaces/MSBuildTest/NewlyCreatedProjectsFromDotNetNew.cs:line 159
   at Microsoft.CodeAnalysis.MSBuild.UnitTests.NewlyCreatedProjectsFromDotNetNew.ValidateVisualBasicTemplateProjects(String templateName) in /_/src/Workspaces/MSBuildTest/NewlyCreatedProjectsFromDotNetNew.cs:line 89
--- End of stack trace from previous location ---
    ❌ Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicEditAndContinue+CommonProjectSystem.LocalsWindowUpdatesCorrectlyDuringEnC [Details] [29.57% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicEditAndContinue+CommonProjectSystem.LocalsWindowUpdatesCorrectlyDuringEnC (VS2022)
      Exception Message
      System.Exception : Could not find locals. Debugger is not running.
      Stack Trace
         at Roslyn.VisualStudio.NewIntegrationTests.InProcess.LocalsWindowInProcess.<GetEntryAsync>d__2.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/LocalsWindowInProcess.cs:line 46
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicEditAndContinue.<LocalsWindowUpdatesCorrectlyDuringEnC>d__15.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/VisualBasic/BasicEditAndContinue.cs:line 306
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Was this helpful? Yes No

View more details on Build Analysis