Reduce allocations in CSharpSyntaxFacts.AppendMembers (again) #74790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change(dotnet#74596) modified this code to take in an ArrayBuilder to allow callers to easily use pooled arrays. However, the size of the data populated into those arrays commonly exceeds the ArrayBuilder reuse threshold, those reducing the allocation benefit realized in those codepaths. This PR changes the callers to instead use a pooled list, thus avoiding the threshold issue. Current scrolling speedometer results for the typing scenario still show this as allocating around 35 MB (which was about 3.5% at the time of the earlier PR). My hope is that this PR will get rid of nearly all those allocations this time.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
changed the title
|
@ToddGrun were you going to run a smoke test for this one? |
Yeah, I was going to post once the PR was created, but here's the pipeline run that will be generating the PR shortly: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10060803&view=results Update: Numbers look a bit wonky to me. Going to make a tweak and re-run the process. |
333fred
reviewed
Aug 16, 2024
CyrusNajmabadi
approved these changes
Aug 19, 2024
3 tasks
…*, this will finally get the allocation reductions, as having each caller own what pool they use was giving me grief.
RikkiGibson
approved these changes
Aug 20, 2024
Did multiple insertion PRs after the last commit, all looks good now. The full 3.5% of SyntaxNode[] allocations look to be gone. https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/573228 |
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change(#74596) modified this code to take in an ArrayBuilder to allow callers to easily use pooled arrays. However, the size of the data populated into those arrays commonly exceeds the ArrayBuilder reuse threshold, those reducing the allocation benefit realized in those codepaths.
This PR changes the callers to instead use a pooled list, thus avoiding the threshold issue. Current scrolling speedometer results for the typing scenario still show this as allocating around 35 MB (which was about 3.5% at the time of the earlier PR, about 4.6% of allocations currently). My hope is that this PR will get rid of nearly all those allocations this time.
*** relevant allocations from the typing scenario in the scrolling speedometer ***
