Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce allocations from newline information allocated by ChangedText.GetLinesCore #74728

Merged
merged 15 commits into from
Aug 22, 2024

Commits on Aug 13, 2024

  1. Reduce allocations from newline information allocated by ChangedText.…

    …GetLinesCore.
    
    Going to start this in draft mode and fire off a test insertion to verify this improves allocations as the typing scenario in speedometer scrolling test shows this as nearly 10% of allocations.
    
    The general idea here is that ChangedText doesn't need to keep track of line information as the SourceText that it wraps has that information. The complexity that was in ChangedText around newline splitting now needs to sit in both CompositeText and SubText as they need to understand how to expose their line collections.
    ToddGrun committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    de1d463 View commit details
    Browse the repository at this point in the history
  2. Fix build error on ci

    ToddGrun committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d3495be View commit details
    Browse the repository at this point in the history
  3. 1) Modify tests to instead just take in a single string, and permute …

    …over all possible source texts generatable from that sequence
    
    2) Move the two added TextLineCollection derivations to be private.
    ToddGrun committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    975340c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ae36fc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    75741f2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    03543db View commit details
    Browse the repository at this point in the history
  7. fsn, seal

    ToddGrun committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1c0bae9 View commit details
    Browse the repository at this point in the history
  8. Missed a semi-colon

    ToddGrun committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    100549a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    41397b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7feb451 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Configuration menu
    Copy the full SHA
    a402198 View commit details
    Browse the repository at this point in the history
  2. Missed one requested assert

    ToddGrun committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    0522300 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Simplification in CompositeText's handling of split \r\n. Instead of …

    …handling in two different locations, just handle it in a single location up front.
    ToddGrun committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2dae6b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Comment

    ToddGrun committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    97b4038 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Update a comment and remove a condition that was preventing setting s…

    …ome data in the empty SubText.UnderlyingSpan case.
    ToddGrun committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    30f47ee View commit details
    Browse the repository at this point in the history