CodeQL fixes #74658
Merged
CodeQL fixes #74658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@dotnet/roslyn-compiler PTAL |
jaredpar
commented
Aug 6, 2024
Comment on lines
+33
to
+40
| static byte[] calculateSha1(IEnumerable<Blob> content) | ||
| { | ||
| hash.AppendData(content); | ||
| return hash.GetHashAndReset(); | ||
| // CodeQL [SM02196] ECMA-335 requires us to use SHA-1 and there is no alternative. | ||
| using (var hash = IncrementalHash.CreateHash(HashAlgorithmName.SHA1)) | ||
| { | ||
| hash.AppendData(content); | ||
| return hash.GetHashAndReset(); | ||
| } |
There was a problem hiding this comment.
Moved this to a local function to make it clear that the scope of the SHA1 usage was this function.
This takes care of a number of CodeQL violations in our code base. Virtually all of these were about uses of MD5 or SHA-1 that we have to support due to the file formats we produce and consume. As such I added suppressions for those cases. There was one real case that could be migrated that I took care of.
cston
approved these changes
Aug 6, 2024
333fred
approved these changes
Aug 6, 2024
chsienki
approved these changes
Aug 6, 2024
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of a number of CodeQL violations in our code base. Virtually all of these were about uses of MD5 or SHA-1 that we have to support due to the file formats we produce and consume. As such I added suppressions for those cases. There was one real case that could be migrated that I took care of.