Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CG issue for Microsoft.IO.Redist #74653

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Fix CG issue for Microsoft.IO.Redist #74653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de10517
Fix CG issue for Microsoft.IO.Redist
jaredpar Aug 5, 2024
8d18a79
Fix
jaredpar Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions eng/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,14 @@
<PackageVersion Include="System.Threading.Channels" Version="7.0.0" />

<!--
System.Net.Http and System.Private.Uri are used to eliminate our reference to old packages with vulnerability.
They are introduced by other component. Tracked issues:https://github.com/xunit/xunit/issues/2778 and https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1886496
Packages that are pinned to avoid component governance alerts.
Tracked issues:
https://github.com/xunit/xunit/issues/2778
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1886496
-->
<PackageVersion Include="System.Net.Http" Version="4.3.4" />
<PackageVersion Include="System.Private.Uri" Version="4.3.2" />
<PackageVersion Include="Microsoft.IO.Redist" Version="6.0.1" />

<PackageVersion Include="SQLitePCLRaw.core" Version="$(SqliteVersion)" />
<PackageVersion Include="SQLitePCLRaw.bundle_green" Version="$(SqliteVersion)" />
Expand Down
1 change: 1 addition & 0 deletions ...kspaces/Core/MSBuild.BuildHost/Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
<PackageReference Include="System.CommandLine" />
<PackageReference Include="System.Collections.Immutable" />
<PackageReference Include="Newtonsoft.Json" />
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Womp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's busted you have to do this, you want all of MSBuild to be Exclude="Runtime"

I wonder if instead of referencing the packages for MSBuild which bring in it's entire NuGet graph, you could just reference the API it exposes. As reference assemblies. cc @baronfel

<PackageReference Include="System.Threading.Tasks.Extensions" Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'" />
</ItemGroup>
<ItemGroup>
Expand Down