Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnC: Implement support for System.Threading.Lock #74526

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 23, 2024

Relates to test plan #71888

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 23, 2024
@tmat tmat marked this pull request as ready for review July 24, 2024 19:50
@tmat tmat requested review from a team as code owners July 24, 2024 19:50
@tmat
Copy link
Member Author

tmat commented Jul 24, 2024

@jjonescz @cston @dotnet/roslyn-compiler PTAL

@@ -10,6 +10,7 @@
using System.Linq;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.PooledObjects;
using Microsoft.CodeAnalysis.Shared.Collections;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks unnecessary.

@RikkiGibson
Copy link
Contributor

Sorry, I missed this notification. I'll try and get to this soon.

Copy link
Contributor

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes under compilers LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers New Feature - Lock Type untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants