Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues with VSIX item publishing projects and FUTDC #74470

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 20, 2024

Workaround missing dependency publishing feature in the VS SDK.

Introduces the following convention: When a project reference publish outputs (i.e. more than standard build outputs) need to be packaged into a VSIX,
the project should define VsixItemsOutputGroup target and include it in ProjectRefrence.IncludeOutputGroupsInVSIX.

VsixItemsOutputGroup target may gather all the publishing items to be packaged into the VSIX using PublishItemsOutputGroup target,
but should not depend on Publish target (i.e. invoking VsixItemsOutputGroup target should not trigger actual publishing).

A custom target run before CreateVsixContainer will take care of publishing for all ProjectReferences with VsixItemsOutputGroup.

@tmat tmat requested review from a team as code owners July 20, 2024 00:06
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 20, 2024
@tmat tmat merged commit 1c09947 into dotnet:main Jul 29, 2024
28 checks passed
@tmat tmat deleted the PublishTargets branch July 29, 2024 15:35
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 29, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants