Avoid producing compilations in Add-Import when we can prove there are no results in that project. #65655
Conversation
| symbolsWithName = symbolsWithName.Select(s => s.GetSymbolKey(cancellationToken).Resolve(startingCompilation, cancellationToken: cancellationToken).Symbol) | ||
| .WhereNotNull() | ||
| .ToImmutableArray(); | ||
| } |
There was a problem hiding this comment.
moved this logic to the caller.
| list.AddRange(FilterByCriteria(symbolsWithName, filter)); | ||
| } | ||
| } | ||
|
|
||
| private static async Task AddMetadataDeclarationsWithNormalQueryAsync( | ||
| Project project, | ||
| IAssemblySymbol assembly, | ||
| PortableExecutableReference? reference, | ||
| AsyncLazy<IAssemblySymbol?> lazyAssembly, |
There was a problem hiding this comment.
changed to lazyAssembly. Avoids creation compilation when no results are found.
| // get declarations from directly referenced projects and metadata | ||
| foreach (var assembly in compilation.GetReferencedAssemblySymbols()) | ||
| // get declarations from directly referenced projects | ||
| foreach (var projectReference in project.ProjectReferences) |
There was a problem hiding this comment.
instead of walking GetReferencedAssemblySymbols (which needs both a compilation, and creates assembly symbols for all references), we can instead just manually walk project-references and metadtareferences, search each (using indices) And only realize the compilation if we find a match.
| @@ -206,6 +206,9 @@ public SymbolTreeInfo WithChecksum(Checksum checksum) | |||
| if (ignoreCase || StringComparer.Ordinal.Equals(name, node.Name)) | |||
| { | |||
| assemblySymbol ??= await lazyAssembly.GetValueAsync(cancellationToken).ConfigureAwait(false); | |||
| if (assemblySymbol is null) | |||
There was a problem hiding this comment.
❔ Where's the source of this null value?
There was a problem hiding this comment.
we are delaying getting the IAssemblySymbol for a particular PE reference, but the compiler does'nt guarantee all pe-references will produce an IAssemblySymbol.
| using var _ = ArrayBuilder<ISymbol>.GetInstance(out var buffer); | ||
|
|
||
| var referencedProject = project.Solution.GetProject(projectReference.ProjectId); | ||
| if (referencedProject is null) |
There was a problem hiding this comment.
is this true when you have a ProjectReference item in the csproj but no project exists on disk for example?
There was a problem hiding this comment.
yeah, i think jason has said this can occur.
ghost
added this to the 
No description provided.