Cleanup the code in FullyQualify #65654
Conversation
|
|
||
| // Actual member name might differ by case. | ||
| string memberName; | ||
| if (IgnoreCase) | ||
| if (ignoreCase) | ||
| { | ||
| var member = container.GetMembers(name).FirstOrDefault(); | ||
| memberName = member != null ? member.Name : name; |
There was a problem hiding this comment.
not your change, but something seems weird here - parts I don't get
- the name given (looks like it comes from
GetNameAndArityOfSimpleName) might not be the right case? - can we always pull the correctly cased name from the actual symbol?
There was a problem hiding this comment.
so that's what we're trying to do here. we're trying to find the actual properly cased symbol name (in the case of vb), but we fallback to the name as the user wrote it in case we don't find that symbol. (note: it seems weird that we wouldn't find it. the code is likely being too paranoid, but i'm not comfortable making a change there in this PR :)).
There was a problem hiding this comment.
yeah the part I didn't get is why we need to fallback to anything. fine to leave it how it is here
| /// </summary> | ||
| internal abstract class AbstractFullyQualifyCodeFixProvider : CodeFixProvider | ||
| { | ||
| // Just to silence analyzer. |
There was a problem hiding this comment.
This is for RS1016?
If it reports for an abstract class, I guess it's a bug?
ghost
added this to the 
Precursor before some larger refactorings.